Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690247 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-18 15:10 +0200 |
| Last post | 2017-07-29 02:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static Colin King <colin.king@canonical.com> - 2017-07-18 15:10 +0200
Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> - 2017-07-20 13:10 +0200
Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-29 02:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-18 15:10 +0200 |
| Subject | [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static |
| Message-ID | <u4Aqd-2Pp-7@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The functions pi433_receive and pi433_tx_thread are local to the source
and do not need to be in global scope, so make them static
Cleans up sparse warnings:
symbol 'pi433_receive' was not declared. Should it be static?
symbol 'pi433_tx_thread' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index d9328ce5ec1d..95930a192de4 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
/*-------------------------------------------------------------------------*/
-int
+static int
pi433_receive(void *data)
{
struct pi433_device *dev = data;
@@ -463,7 +463,7 @@ pi433_receive(void *data)
return bytes_total;
}
-int
+static int
pi433_tx_thread(void *data)
{
struct pi433_device *device = data;
--
2.11.0
[toc] | [next] | [standalone]
| From | "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> |
|---|---|
| Date | 2017-07-20 13:10 +0200 |
| Subject | Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static |
| Message-ID | <u5hve-6vT-23@gated-at.bofh.it> |
| In reply to | #1690247 |
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions pi433_receive and pi433_tx_thread are local to the source
> and do not need to be in global scope, so make them static
>
> Cleans up sparse warnings:
> symbol 'pi433_receive' was not declared. Should it be static?
> symbol 'pi433_tx_thread' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d9328ce5ec1d..95930a192de4 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
>
> /*-------------------------------------------------------------------------*/
>
> -int
> +static int
> pi433_receive(void *data)
> {
> struct pi433_device *dev = data;
> @@ -463,7 +463,7 @@ pi433_receive(void *data)
> return bytes_total;
> }
>
> -int
> +static int
> pi433_tx_thread(void *data)
> {
> struct pi433_device *device = data;
> --
> 2.11.0
>
>
>
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-29 02:00 +0200 |
| Subject | Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static |
| Message-ID | <u8nkK-2hg-11@gated-at.bofh.it> |
| In reply to | #1690247 |
On Tue, Jul 18, 2017 at 02:03:58PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The functions pi433_receive and pi433_tx_thread are local to the source > and do not need to be in global scope, so make them static > > Cleans up sparse warnings: > symbol 'pi433_receive' was not declared. Should it be static? > symbol 'pi433_tx_thread' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de> Only one of the patches in this series applied :(
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web