Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692530 > unrolled thread

[PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test Christoph Hellwig <hch@lst.de> - 2017-07-20 10:00 +0200
    Re: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test Amir Goldstein <amir73il@gmail.com> - 2017-07-20 11:00 +0200

#1692530 — [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test

Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/test_uuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_uuid.c b/lib/test_uuid.c
index 478c049630b5..cd819c397dc7 100644
--- a/lib/test_uuid.c
+++ b/lib/test_uuid.c
@@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
 		test_uuid_failed("conversion", false, true, data->uuid, NULL);
 
 	total_tests++;
-	if (uuid_equal(&data->be, &be)) {
+	if (!uuid_equal(&data->be, &be)) {
 		sprintf(buf, "%pUb", &be);
 		test_uuid_failed("cmp", false, true, data->uuid, buf);
 	}
-- 
2.11.0

[toc] | [next] | [standalone]

#1692612

On Thu, Jul 20, 2017 at 10:56 AM, Christoph Hellwig <hch@lst.de> wrote:
> Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
> Reported-by: kernel test robot <xiaolong.ye@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Oops
Reviewed-by: Amir Goldstein <amir73il@gmail.com>


> ---
>  lib/test_uuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_uuid.c b/lib/test_uuid.c
> index 478c049630b5..cd819c397dc7 100644
> --- a/lib/test_uuid.c
> +++ b/lib/test_uuid.c
> @@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
>                 test_uuid_failed("conversion", false, true, data->uuid, NULL);
>
>         total_tests++;
> -       if (uuid_equal(&data->be, &be)) {
> +       if (!uuid_equal(&data->be, &be)) {
>                 sprintf(buf, "%pUb", &be);
>                 test_uuid_failed("cmp", false, true, data->uuid, buf);
>         }
> --
> 2.11.0
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web