Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692529 > unrolled thread
| Started by | Christoph Hellwig <hch@lst.de> |
|---|---|
| First post | 2017-07-20 10:00 +0200 |
| Last post | 2017-07-24 18:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] thunderbold: use uuid_t instead of uuid_be Christoph Hellwig <hch@lst.de> - 2017-07-20 10:00 +0200
Re: [PATCH 2/3] thunderbold: use uuid_t instead of uuid_be Amir Goldstein <amir73il@gmail.com> - 2017-07-20 11:10 +0200
Re: [PATCH 2/3] thunderbold: use uuid_t instead of uuid_be Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-07-24 11:30 +0200
Re: [PATCH 2/3] thunderbold: use uuid_t instead of uuid_be Christoph Hellwig <hch@lst.de> - 2017-07-24 18:00 +0200
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-07-20 10:00 +0200 |
| Subject | [PATCH 2/3] thunderbold: use uuid_t instead of uuid_be |
| Message-ID | <u5exk-4e2-17@gated-at.bofh.it> |
Switch thunderbolt to the new uuid type.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/thunderbolt/switch.c | 8 ++++----
drivers/thunderbolt/tb.h | 4 ++--
drivers/thunderbolt/tb_msgs.h | 12 ++++++------
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index ab3e8f410444..c6f41b7d38b0 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -30,7 +30,7 @@ static DEFINE_IDA(nvm_ida);
struct nvm_auth_status {
struct list_head list;
- uuid_be uuid;
+ uuid_t uuid;
u32 status;
};
@@ -47,7 +47,7 @@ static struct nvm_auth_status *__nvm_get_auth_status(const struct tb_switch *sw)
struct nvm_auth_status *st;
list_for_each_entry(st, &nvm_auth_status_cache, list) {
- if (!uuid_be_cmp(st->uuid, *sw->uuid))
+ if (uuid_equal(&st->uuid, sw->uuid))
return st;
}
@@ -1460,7 +1460,7 @@ struct tb_sw_lookup {
struct tb *tb;
u8 link;
u8 depth;
- const uuid_be *uuid;
+ const uuid_t *uuid;
};
static int tb_switch_match(struct device *dev, void *data)
@@ -1517,7 +1517,7 @@ struct tb_switch *tb_switch_find_by_link_depth(struct tb *tb, u8 link, u8 depth)
* Returned switch has reference count increased so the caller needs to
* call tb_switch_put() when done with the switch.
*/
-struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_be *uuid)
+struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_t *uuid)
{
struct tb_sw_lookup lookup;
struct device *dev;
diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
index 3d9f64676e58..e0deee4f1eb0 100644
--- a/drivers/thunderbolt/tb.h
+++ b/drivers/thunderbolt/tb.h
@@ -101,7 +101,7 @@ struct tb_switch {
struct tb_dma_port *dma_port;
struct tb *tb;
u64 uid;
- uuid_be *uuid;
+ uuid_t *uuid;
u16 vendor;
u16 device;
const char *vendor_name;
@@ -407,7 +407,7 @@ void tb_sw_set_unplugged(struct tb_switch *sw);
struct tb_switch *get_switch_at_route(struct tb_switch *sw, u64 route);
struct tb_switch *tb_switch_find_by_link_depth(struct tb *tb, u8 link,
u8 depth);
-struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_be *uuid);
+struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_t *uuid);
static inline unsigned int tb_switch_phy_port_from_link(unsigned int link)
{
diff --git a/drivers/thunderbolt/tb_msgs.h b/drivers/thunderbolt/tb_msgs.h
index 85b6d33c0919..de6441e4a060 100644
--- a/drivers/thunderbolt/tb_msgs.h
+++ b/drivers/thunderbolt/tb_msgs.h
@@ -179,7 +179,7 @@ struct icm_fr_pkg_get_topology_response {
struct icm_fr_event_device_connected {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 link_info;
@@ -193,7 +193,7 @@ struct icm_fr_event_device_connected {
struct icm_fr_pkg_approve_device {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 reserved;
@@ -207,7 +207,7 @@ struct icm_fr_event_device_disconnected {
struct icm_fr_pkg_add_device_key {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 reserved;
@@ -216,7 +216,7 @@ struct icm_fr_pkg_add_device_key {
struct icm_fr_pkg_add_device_key_response {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 reserved;
@@ -224,7 +224,7 @@ struct icm_fr_pkg_add_device_key_response {
struct icm_fr_pkg_challenge_device {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 reserved;
@@ -233,7 +233,7 @@ struct icm_fr_pkg_challenge_device {
struct icm_fr_pkg_challenge_device_response {
struct icm_pkg_header hdr;
- uuid_be ep_uuid;
+ uuid_t ep_uuid;
u8 connection_key;
u8 connection_id;
u16 reserved;
--
2.11.0
[toc] | [next] | [standalone]
| From | Amir Goldstein <amir73il@gmail.com> |
|---|---|
| Date | 2017-07-20 11:10 +0200 |
| Message-ID | <u5fD5-5dz-41@gated-at.bofh.it> |
| In reply to | #1692529 |
On Thu, Jul 20, 2017 at 10:56 AM, Christoph Hellwig <hch@lst.de> wrote:
> Switch thunderbolt to the new uuid type.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> drivers/thunderbolt/switch.c | 8 ++++----
> drivers/thunderbolt/tb.h | 4 ++--
> drivers/thunderbolt/tb_msgs.h | 12 ++++++------
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
> index ab3e8f410444..c6f41b7d38b0 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -30,7 +30,7 @@ static DEFINE_IDA(nvm_ida);
>
> struct nvm_auth_status {
> struct list_head list;
> - uuid_be uuid;
> + uuid_t uuid;
> u32 status;
> };
>
> @@ -47,7 +47,7 @@ static struct nvm_auth_status *__nvm_get_auth_status(const struct tb_switch *sw)
> struct nvm_auth_status *st;
>
> list_for_each_entry(st, &nvm_auth_status_cache, list) {
> - if (!uuid_be_cmp(st->uuid, *sw->uuid))
> + if (uuid_equal(&st->uuid, sw->uuid))
> return st;
> }
>
> @@ -1460,7 +1460,7 @@ struct tb_sw_lookup {
> struct tb *tb;
> u8 link;
> u8 depth;
> - const uuid_be *uuid;
> + const uuid_t *uuid;
> };
>
> static int tb_switch_match(struct device *dev, void *data)
> @@ -1517,7 +1517,7 @@ struct tb_switch *tb_switch_find_by_link_depth(struct tb *tb, u8 link, u8 depth)
> * Returned switch has reference count increased so the caller needs to
> * call tb_switch_put() when done with the switch.
> */
> -struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_be *uuid)
> +struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_t *uuid)
> {
> struct tb_sw_lookup lookup;
> struct device *dev;
> diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
> index 3d9f64676e58..e0deee4f1eb0 100644
> --- a/drivers/thunderbolt/tb.h
> +++ b/drivers/thunderbolt/tb.h
> @@ -101,7 +101,7 @@ struct tb_switch {
> struct tb_dma_port *dma_port;
> struct tb *tb;
> u64 uid;
> - uuid_be *uuid;
> + uuid_t *uuid;
> u16 vendor;
> u16 device;
> const char *vendor_name;
> @@ -407,7 +407,7 @@ void tb_sw_set_unplugged(struct tb_switch *sw);
> struct tb_switch *get_switch_at_route(struct tb_switch *sw, u64 route);
> struct tb_switch *tb_switch_find_by_link_depth(struct tb *tb, u8 link,
> u8 depth);
> -struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_be *uuid);
> +struct tb_switch *tb_switch_find_by_uuid(struct tb *tb, const uuid_t *uuid);
>
> static inline unsigned int tb_switch_phy_port_from_link(unsigned int link)
> {
> diff --git a/drivers/thunderbolt/tb_msgs.h b/drivers/thunderbolt/tb_msgs.h
> index 85b6d33c0919..de6441e4a060 100644
> --- a/drivers/thunderbolt/tb_msgs.h
> +++ b/drivers/thunderbolt/tb_msgs.h
> @@ -179,7 +179,7 @@ struct icm_fr_pkg_get_topology_response {
>
> struct icm_fr_event_device_connected {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 link_info;
> @@ -193,7 +193,7 @@ struct icm_fr_event_device_connected {
>
> struct icm_fr_pkg_approve_device {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 reserved;
> @@ -207,7 +207,7 @@ struct icm_fr_event_device_disconnected {
>
> struct icm_fr_pkg_add_device_key {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 reserved;
> @@ -216,7 +216,7 @@ struct icm_fr_pkg_add_device_key {
>
> struct icm_fr_pkg_add_device_key_response {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 reserved;
> @@ -224,7 +224,7 @@ struct icm_fr_pkg_add_device_key_response {
>
> struct icm_fr_pkg_challenge_device {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 reserved;
> @@ -233,7 +233,7 @@ struct icm_fr_pkg_challenge_device {
>
> struct icm_fr_pkg_challenge_device_response {
> struct icm_pkg_header hdr;
> - uuid_be ep_uuid;
> + uuid_t ep_uuid;
> u8 connection_key;
> u8 connection_id;
> u16 reserved;
> --
> 2.11.0
>
[toc] | [prev] | [next] | [standalone]
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-07-24 11:30 +0200 |
| Message-ID | <u6HQC-2Si-15@gated-at.bofh.it> |
| In reply to | #1692529 |
On Thu, Jul 20, 2017 at 09:56:23AM +0200, Christoph Hellwig wrote: > Switch thunderbolt to the new uuid type. > > Signed-off-by: Christoph Hellwig <hch@lst.de> You have a typo in $subject: thunderbold -> thunderbolt. Otherwise looks good and still works fine :) Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-07-24 18:00 +0200 |
| Message-ID | <u6NW2-6Tk-29@gated-at.bofh.it> |
| In reply to | #1694574 |
On Mon, Jul 24, 2017 at 12:28:59PM +0300, Mika Westerberg wrote: > On Thu, Jul 20, 2017 at 09:56:23AM +0200, Christoph Hellwig wrote: > > Switch thunderbolt to the new uuid type. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > You have a typo in $subject: thunderbold -> thunderbolt. > > Otherwise looks good and still works fine :) Thanks, fixed.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web