Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692510 > unrolled thread

[PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda <kgunda@codeaurora.org> - 2017-07-20 09:40 +0200
    Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with  __raw_writel Stephen Boyd <sboyd@codeaurora.org> - 2017-07-28 02:10 +0200
      Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with  __raw_writel kgunda@codeaurora.org - 2017-07-28 07:40 +0200

#1692510 — [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

Replace the writel_relaxed with __raw_writel to avoid byte swapping
in pmic_arb_write_data() function. That way the code is independent
of the CPU endianness.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index b32b5b0..a18ff99 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -230,7 +230,7 @@ static void pmic_arb_write_data(struct spmi_pmic_arb *pmic_arb, const u8 *buf,
 	u32 data = 0;
 
 	memcpy(&data, buf, (bc & 3) + 1);
-	pmic_arb_base_write(pmic_arb, reg, data);
+	__raw_writel(data, pmic_arb->wr_base + reg);
 }
 
 static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1698372 — Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

On 07/20, Kiran Gunda wrote:
> Replace the writel_relaxed with __raw_writel to avoid byte swapping
> in pmic_arb_write_data() function. That way the code is independent
> of the CPU endianness.
> 
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

This also needs a Fixes tag.

Fixes: 111a10bf3e53 ("spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb")

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1698477 — Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

On 2017-07-28 05:31, Stephen Boyd wrote:
> On 07/20, Kiran Gunda wrote:
>> Replace the writel_relaxed with __raw_writel to avoid byte swapping
>> in pmic_arb_write_data() function. That way the code is independent
>> of the CPU endianness.
>> 
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> This also needs a Fixes tag.
> 
> Fixes: 111a10bf3e53 ("spmi: pmic-arb: rename spmi_pmic_arb_dev to
> spmi_pmic_arb")
Sure. will add the tag and send the patch.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web