Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691156 > unrolled thread

[PATCH] Crypto: atmel-ecc: Make a couple of local functions static

Back to article view | Back to linux.kernel

Contents

  [PATCH] Crypto: atmel-ecc: Make a couple of local functions static Colin King <colin.king@canonical.com> - 2017-07-19 11:30 +0200
    Re: [PATCH] Crypto: atmel-ecc: Make a couple of local functions  static Tudor Ambarus <tudor.ambarus@microchip.com> - 2017-07-20 09:10 +0200

#1691156 — [PATCH] Crypto: atmel-ecc: Make a couple of local functions static

From: Colin Ian King <colin.king@canonical.com>

Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are
local to the source and no not need to be in the global scope. Make
them static.

Cleans up sparse warnings:
symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static?
symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/crypto/atmel-ecc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index 66ab1021eba5..c6e8de2b28dd 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -492,7 +492,7 @@ static int atmel_ecdh_compute_shared_secret(struct kpp_request *req)
 	return ret;
 }
 
-struct i2c_client *atmel_ecc_i2c_client_alloc(void)
+static struct i2c_client *atmel_ecc_i2c_client_alloc(void)
 {
 	struct atmel_ecc_i2c_client_priv *i2c_priv, *min_i2c_priv = NULL;
 	struct i2c_client *client = ERR_PTR(-ENODEV);
@@ -527,7 +527,7 @@ struct i2c_client *atmel_ecc_i2c_client_alloc(void)
 	return client;
 }
 
-void atmel_ecc_i2c_client_free(struct i2c_client *client)
+static void atmel_ecc_i2c_client_free(struct i2c_client *client)
 {
 	struct atmel_ecc_i2c_client_priv *i2c_priv = i2c_get_clientdata(client);
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1692479 — Re: [PATCH] Crypto: atmel-ecc: Make a couple of local functions static

On 07/19/2017 12:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are
> local to the source and no not need to be in the global scope. Make
> them static.
> 
> Cleans up sparse warnings:
> symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static?
> symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Thanks,
ta

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web