Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1694141 > unrolled thread
| Started by | Paolo Cretaro <paolocretaro@gmail.com> |
|---|---|
| First post | 2017-07-22 12:30 +0200 |
| Last post | 2017-07-22 12:40 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] staging: pi433: use IS_ERR to check kthread_run return value Paolo Cretaro <paolocretaro@gmail.com> - 2017-07-22 12:30 +0200
Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value Paolo Cretaro <paolocretaro@gmail.com> - 2017-07-22 12:40 +0200
| From | Paolo Cretaro <paolocretaro@gmail.com> |
|---|---|
| Date | 2017-07-22 12:30 +0200 |
| Subject | [PATCH] staging: pi433: use IS_ERR to check kthread_run return value |
| Message-ID | <u5ZPA-Jq-11@gated-at.bofh.it> |
Fix compiler warning: ordered comparison of pointer with integer zero
Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 1bc478a7f49e..79bd19123239 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
device->tx_task_struct = kthread_run(pi433_tx_thread,
device,
"pi433_tx_task");
- if (device->tx_task_struct < 0)
+ if (IS_ERR(device->tx_task_struct))
{
dev_dbg(device->dev, "start of send thread failed");
goto send_thread_failed;
--
2.13.3
[toc] | [next] | [standalone]
| From | Paolo Cretaro <paolocretaro@gmail.com> |
|---|---|
| Date | 2017-07-22 12:40 +0200 |
| Subject | Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value |
| Message-ID | <u5ZZf-MC-3@gated-at.bofh.it> |
| In reply to | #1694141 |
On 22/07/2017 12:27, Paolo Cretaro wrote:
> Fix compiler warning: ordered comparison of pointer with integer zero
Sorry, just noticed a similar patch has been submitted a few days ago,
please ignore this patch.
Paolo
>
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 1bc478a7f49e..79bd19123239 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_task_struct = kthread_run(pi433_tx_thread,
> device,
> "pi433_tx_task");
> - if (device->tx_task_struct < 0)
> + if (IS_ERR(device->tx_task_struct))
> {
> dev_dbg(device->dev, "start of send thread failed");
> goto send_thread_failed;
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web