Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694054 > unrolled thread

Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after  swapped out Andrew Morton <akpm@linux-foundation.org> - 2017-07-22 01:30 +0200
    Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out "Huang\, Ying" <ying.huang@intel.com> - 2017-07-24 03:00 +0200
      Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after  swapped out Ming Lei <ming.lei@redhat.com> - 2017-07-24 04:50 +0200

#1694054 — Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out

On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:

> From: Huang Ying <ying.huang@intel.com>
> 
> Hi, Andrew, could you help me to check whether the overall design is
> reasonable?
> 
> Hi, Johannes and Minchan, Thanks a lot for your review to the first
> step of the THP swap optimization!  Could you help me to review the
> second step in this patchset?
> 
> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
> swap part of the patchset?  Especially [01/12], [02/12], [03/12],
> [04/12], [11/12], and [12/12].
> 
> Hi, Andrea and Kirill, could you help me to review the THP part of the
> patchset?  Especially [01/12], [03/12], [07/12], [08/12], [09/12],
> [11/12].
> 
> Hi, Johannes, Michal, could you help me to review the cgroup part of
> the patchset?  Especially [08/12], [09/12], and [10/12].
> 
> And for all, Any comment is welcome!

I guess it's time for a resend.  Folks, could we please get some more
review&test going here?

> Because the THP swap writing support patch [06/12] needs to be rebased
> on multipage bvec patchset which hasn't been merged yet.  The [06/12]
> in this patchset is just a test patch and will be rewritten later.
> The patchset depends on multipage bvec patchset too.

Are these dependency issues any simpler now?

> This is the second step of THP (Transparent Huge Page) swap
> optimization.  In the first step, the splitting huge page is delayed
> from almost the first step of swapping out to after allocating the
> swap space for the THP and adding the THP into the swap cache.  In the
> second step, the splitting is delayed further to after the swapping
> out finished.  The plan is to delay splitting THP step by step,
> finally avoid splitting THP for the THP swapping out and swap out/in
> the THP as a whole.
> 
> In the patchset, more operations for the anonymous THP reclaiming,
> such as TLB flushing, writing the THP to the swap device, removing the
> THP from the swap cache are batched.  So that the performance of
> anonymous THP swapping out are improved.
> 

[toc] | [next] | [standalone]

#1694383 — Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out

Andrew Morton <akpm@linux-foundation.org> writes:

> On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> Hi, Andrew, could you help me to check whether the overall design is
>> reasonable?
>> 
>> Hi, Johannes and Minchan, Thanks a lot for your review to the first
>> step of the THP swap optimization!  Could you help me to review the
>> second step in this patchset?
>> 
>> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
>> swap part of the patchset?  Especially [01/12], [02/12], [03/12],
>> [04/12], [11/12], and [12/12].
>> 
>> Hi, Andrea and Kirill, could you help me to review the THP part of the
>> patchset?  Especially [01/12], [03/12], [07/12], [08/12], [09/12],
>> [11/12].
>> 
>> Hi, Johannes, Michal, could you help me to review the cgroup part of
>> the patchset?  Especially [08/12], [09/12], and [10/12].
>> 
>> And for all, Any comment is welcome!
>
> I guess it's time for a resend.  Folks, could we please get some more
> review&test going here?

Sure.  Will resend it ASAP.  And Thanks for reminding!

>> Because the THP swap writing support patch [06/12] needs to be rebased
>> on multipage bvec patchset which hasn't been merged yet.  The [06/12]
>> in this patchset is just a test patch and will be rewritten later.
>> The patchset depends on multipage bvec patchset too.
>
> Are these dependency issues any simpler now?

Ming Lei has sent the v2 of multipage bvec patchset on June 26th.  Jens
Axboe thinks the patchset will target v4.14.

https://lkml.org/lkml/2017/6/26/538

Best Regards,
Huang, Ying

>> This is the second step of THP (Transparent Huge Page) swap
>> optimization.  In the first step, the splitting huge page is delayed
>> from almost the first step of swapping out to after allocating the
>> swap space for the THP and adding the THP into the swap cache.  In the
>> second step, the splitting is delayed further to after the swapping
>> out finished.  The plan is to delay splitting THP step by step,
>> finally avoid splitting THP for the THP swapping out and swap out/in
>> the THP as a whole.
>> 
>> In the patchset, more operations for the anonymous THP reclaiming,
>> such as TLB flushing, writing the THP to the swap device, removing the
>> THP from the swap cache are batched.  So that the performance of
>> anonymous THP swapping out are improved.
>> 

[toc] | [prev] | [next] | [standalone]

#1694414

On Mon, Jul 24, 2017 at 08:57:48AM +0800, Huang, Ying wrote:
> Andrew Morton <akpm@linux-foundation.org> writes:
> 
> > On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
> >
> >> From: Huang Ying <ying.huang@intel.com>
> >> 
> >> Hi, Andrew, could you help me to check whether the overall design is
> >> reasonable?
> >> 
> >> Hi, Johannes and Minchan, Thanks a lot for your review to the first
> >> step of the THP swap optimization!  Could you help me to review the
> >> second step in this patchset?
> >> 
> >> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
> >> swap part of the patchset?  Especially [01/12], [02/12], [03/12],
> >> [04/12], [11/12], and [12/12].
> >> 
> >> Hi, Andrea and Kirill, could you help me to review the THP part of the
> >> patchset?  Especially [01/12], [03/12], [07/12], [08/12], [09/12],
> >> [11/12].
> >> 
> >> Hi, Johannes, Michal, could you help me to review the cgroup part of
> >> the patchset?  Especially [08/12], [09/12], and [10/12].
> >> 
> >> And for all, Any comment is welcome!
> >
> > I guess it's time for a resend.  Folks, could we please get some more
> > review&test going here?
> 
> Sure.  Will resend it ASAP.  And Thanks for reminding!
> 
> >> Because the THP swap writing support patch [06/12] needs to be rebased
> >> on multipage bvec patchset which hasn't been merged yet.  The [06/12]
> >> in this patchset is just a test patch and will be rewritten later.
> >> The patchset depends on multipage bvec patchset too.
> >
> > Are these dependency issues any simpler now?
> 
> Ming Lei has sent the v2 of multipage bvec patchset on June 26th.  Jens
> Axboe thinks the patchset will target v4.14.
> 
> https://lkml.org/lkml/2017/6/26/538

I will rebase the patchset against v4.13-rcX and send v3 out later.


Thanks,
Ming

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web