Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1694002 > unrolled thread
| Started by | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| First post | 2017-07-21 23:50 +0200 |
| Last post | 2017-07-22 01:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-07-21 23:50 +0200
Re: [PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init() Darren Hart <dvhart@infradead.org> - 2017-07-22 01:50 +0200
| From | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| Date | 2017-07-21 23:50 +0200 |
| Subject | [PATCH] platform/x86: wmi: Fix error handling in acpi_wmi_init() |
| Message-ID | <u5NY5-1DW-3@gated-at.bofh.it> |
The order of resource deallocations is messed up in acpi_wmi_init(). It should be vice versa. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 1a764e311e11..e32ba575e8d9 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1252,12 +1252,12 @@ static int __init acpi_wmi_init(void) return 0; -err_unreg_class: - class_unregister(&wmi_bus_class); - err_unreg_bus: bus_unregister(&wmi_bus_type); +err_unreg_class: + class_unregister(&wmi_bus_class); + return error; } -- 2.7.4
[toc] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2017-07-22 01:50 +0200 |
| Message-ID | <u5PQe-2MJ-3@gated-at.bofh.it> |
| In reply to | #1694002 |
On Sat, Jul 22, 2017 at 12:48:06AM +0300, Alexey Khoroshilov wrote: > The order of resource deallocations is messed up in acpi_wmi_init(). > It should be vice versa. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Eeek. Thank you. Applied to fixes for 4.13.X. -- Darren Hart VMware Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web