Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693921 > unrolled thread

Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and  Cherry Trail CRC variants Hans de Goede <hdegoede@redhat.com> - 2017-07-21 20:50 +0200
    Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and  Cherry Trail CRC variants Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-21 21:30 +0200

#1693921 — Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants

Hi,

On 18-07-17 09:17, Lee Jones wrote:
> On Mon, 17 Jul 2017, Andy Shevchenko wrote:
> 
>> On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote:
>>> On Sat, 01 Jul 2017, Hans de Goede wrote:
>>>
>>>> Both Bay and Cherry Trail devices may be used together with a
>>>> Crystal Cove
>>>> PMIC. Each platform has its own variant of the PMIC, which both use
>>>> the
>>>> same ACPI HID, but they are not 100% compatible.
>>>>
>>>> This commits makes the intel_soc_pmic_core code check the _HRV of
>>>> the
>>>> ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp.
>>>> intel_soc_pmic_config_cht_crc based on this.
>>>>
>>>> This fixes the Bay Trail specific ACPI OpRegion code causing
>>>> problems
>>>> on Cherry Trail devices. Specifically this was causing the external
>>>> microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not
>>>> work
>>>> and the eMMC to become unreliable and throw lots of errors.
>>>>
>>>> Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru
>>>>>
>>>
>>> Real names only please.
>>>
>>> What is the name of this reporter/tester?
>>
>> No one knows, I think.
> 
> Then I don't think we can credit him/her for their efforts.
> SubmittingPatches clearly states "no pseudonyms or anonymous
> contributions".  Either write to them and ask for their real name so
> that they can be credited, or remove the line.

russianneuromancer has been a great help with reporting and testing
many Bay Trail / Cherry Trail issues. He does not want to use his
real name.

AFAIK the Real Name rule only applies tot he Signed-off-by tag, no
other subsys-maintainers have had problems with listing him as
reporter / tester using his alias.

The Real Name only rule is part of "11) Sign your work — the
Developer’s Certificate of Origin" of :

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Which is all about the S-o-b tag. If you despite this still want
a new version with russianneuromancer's Reported-and-tested-by
dropped let me know and I will send a new version.

Regards,

Hans

[toc] | [next] | [standalone]

#1693937

On Fri, 2017-07-21 at 20:41 +0200, Hans de Goede wrote:
> On 18-07-17 09:17, Lee Jones wrote:
> > On Mon, 17 Jul 2017, Andy Shevchenko wrote:
> > 
> > > On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote:
> > > > On Sat, 01 Jul 2017, Hans de Goede wrote:
> > > > 

> > > > > Reported-and-tested-by: russianneuromancer
> > > > > <russianneuromancer@ya.ru
> > > > > > 
> > > > 
> > > > Real names only please.
> > > > 
> > > > What is the name of this reporter/tester?
> > > 
> > > No one knows, I think.
> > 
> > Then I don't think we can credit him/her for their efforts.
> > SubmittingPatches clearly states "no pseudonyms or anonymous
> > contributions".  Either write to them and ask for their real name so
> > that they can be credited, or remove the line.
> 
> russianneuromancer has been a great help with reporting and testing
> many Bay Trail / Cherry Trail issues. He does not want to use his
> real name.
> 
> AFAIK the Real Name rule only applies tot he Signed-off-by tag, no
> other subsys-maintainers have had problems with listing him as
> reporter / tester using his alias.
> 
> The Real Name only rule is part of "11) Sign your work — the
> Developer’s Certificate of Origin" of :
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> #sign-your-work-the-developer-s-certificate-of-origin
> 
> Which is all about the S-o-b tag. If you despite this still want
> a new version with russianneuromancer's Reported-and-tested-by
> dropped let me know and I will send a new version.

I saw some patches applied just with email in tags like Reported-by.

So, I think everyone will be okay if you remove nick and leave email
only.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web