Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693828 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-07-21 18:20 +0200 |
| Last post | 2017-07-24 08:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS Arnd Bergmann <arnd@arndb.de> - 2017-07-21 18:20 +0200
Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS "Javali, Nilesh" <Nilesh.Javali@cavium.com> - 2017-07-24 08:50 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-21 18:20 +0200 |
| Subject | [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS |
| Message-ID | <u5IOJ-73n-13@gated-at.bofh.it> |
Without the base library support, we get a link failure
drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
qedi_main.c:(.text+0x2d8e): undefined reference to `iscsi_boot_create_target'
qedi_main.c:(.text+0x2dee): undefined reference to `iscsi_boot_create_initiator'
qedi_main.c:(.text+0x2e1c): undefined reference to `iscsi_boot_create_ethernet'
This selects the Kconfig symbol like the other two users of that
module do.
Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over iSCSI offload")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/scsi/qedi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
index 21331453db7b..8deb8723c4dd 100644
--- a/drivers/scsi/qedi/Kconfig
+++ b/drivers/scsi/qedi/Kconfig
@@ -2,6 +2,7 @@ config QEDI
tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
depends on PCI && SCSI && UIO
depends on QED
+ select ISCSI_BOOT_SYSFS
select SCSI_ISCSI_ATTRS
select QED_LL2
select QED_ISCSI
--
2.9.0
[toc] | [next] | [standalone]
| From | "Javali, Nilesh" <Nilesh.Javali@cavium.com> |
|---|---|
| Date | 2017-07-24 08:50 +0200 |
| Message-ID | <u6FlL-1fV-9@gated-at.bofh.it> |
| In reply to | #1693828 |
On 21/07/17, 9:41 PM, "Arnd Bergmann" <arnd@arndb.de> wrote:
>Without the base library support, we get a link failure
>
>drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
>qedi_main.c:(.text+0x2d8e): undefined reference to
>`iscsi_boot_create_target'
>qedi_main.c:(.text+0x2dee): undefined reference to
>`iscsi_boot_create_initiator'
>qedi_main.c:(.text+0x2e1c): undefined reference to
>`iscsi_boot_create_ethernet'
>
>This selects the Kconfig symbol like the other two users of that
>module do.
>
>Fixes: c57ec8fb7c02 ("scsi: qedi: Add support for Boot from SAN over
>iSCSI offload")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/scsi/qedi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
>index 21331453db7b..8deb8723c4dd 100644
>--- a/drivers/scsi/qedi/Kconfig
>+++ b/drivers/scsi/qedi/Kconfig
>@@ -2,6 +2,7 @@ config QEDI
> tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
> depends on PCI && SCSI && UIO
> depends on QED
>+ select ISCSI_BOOT_SYSFS
> select SCSI_ISCSI_ATTRS
> select QED_LL2
> select QED_ISCSI
>--
>2.9.0
>
NACK. The fix already posted to address this issue,
http://marc.info/?l=linux-scsi&m=150045528332067&w=2
Thanks,
Nilesh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web