Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693497 > unrolled thread
| Started by | John Crispin <john@phrozen.org> |
|---|---|
| First post | 2017-07-21 11:10 +0200 |
| Last post | 2017-07-26 17:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file John Crispin <john@phrozen.org> - 2017-07-21 11:10 +0200
Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file David Miller <davem@davemloft.net> - 2017-07-21 21:20 +0200
Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file Andrew Lunn <andrew@lunn.ch> - 2017-07-26 17:00 +0200
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2017-07-21 11:10 +0200 |
| Subject | [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file |
| Message-ID | <u5BWW-2C2-27@gated-at.bofh.it> |
We need to access this struct from within the flow_dissector to fix
dissection for packets coming in on DSA devices.
Signed-off-by: John Crispin <john@phrozen.org>
---
include/net/dsa.h | 7 +++++++
net/dsa/dsa_priv.h | 7 -------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/net/dsa.h b/include/net/dsa.h
index 88da272d20d0..a4c0d52abc80 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -101,6 +101,13 @@ struct dsa_platform_data {
struct packet_type;
+struct dsa_device_ops {
+ struct sk_buff *(*xmit)(struct sk_buff *skb, struct net_device *dev);
+ struct sk_buff *(*rcv)(struct sk_buff *skb, struct net_device *dev,
+ struct packet_type *pt,
+ struct net_device *orig_dev);
+};
+
struct dsa_switch_tree {
struct list_head list;
diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
index 55982cc39b24..62ea3663c2c6 100644
--- a/net/dsa/dsa_priv.h
+++ b/net/dsa/dsa_priv.h
@@ -65,13 +65,6 @@ struct dsa_notifier_vlan_info {
int port;
};
-struct dsa_device_ops {
- struct sk_buff *(*xmit)(struct sk_buff *skb, struct net_device *dev);
- struct sk_buff *(*rcv)(struct sk_buff *skb, struct net_device *dev,
- struct packet_type *pt,
- struct net_device *orig_dev);
-};
-
struct dsa_slave_priv {
/* Copy of dp->ds->dst->tag_ops->xmit for faster access in hot path */
struct sk_buff * (*xmit)(struct sk_buff *skb,
--
2.11.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-21 21:20 +0200 |
| Subject | Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file |
| Message-ID | <u5LCV-lm-1@gated-at.bofh.it> |
| In reply to | #1693497 |
A proper patch series submission must always have a proper "[PATCH 0/N] ..." header posting that explains at a high level what the patch series does, how it is doing it, and why it is doing it that way. Thank you.
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-07-26 17:00 +0200 |
| Subject | Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file |
| Message-ID | <u7vX4-1Cp-23@gated-at.bofh.it> |
| In reply to | #1693497 |
On Fri, Jul 21, 2017 at 10:58:10AM +0200, John Crispin wrote:
> We need to access this struct from within the flow_dissector to fix
> dissection for packets coming in on DSA devices.
>
> Signed-off-by: John Crispin <john@phrozen.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web