Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1690647 > unrolled thread

[PATCH] net: tulip: remove useless code in tulip_init_one()

Started by"Gustavo A. R. Silva" <gustavo@embeddedor.com>
First post2017-07-18 23:10 +0200
Last post2017-07-20 01:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: tulip: remove useless code in tulip_init_one() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-18 23:10 +0200
    Re: [PATCH] net: tulip: remove useless code in tulip_init_one() David Miller <davem@davemloft.net> - 2017-07-20 01:40 +0200

#1690647 — [PATCH] net: tulip: remove useless code in tulip_init_one()

From"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date2017-07-18 23:10 +0200
Subject[PATCH] net: tulip: remove useless code in tulip_init_one()
Message-ID<u4HUJ-7vU-1@gated-at.bofh.it>
Remove useless local variable multiport_cnt and the code related.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/dec/tulip/tulip_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 17e566a..84394b4 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1303,7 +1303,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		0x00, 'L', 'i', 'n', 'u', 'x'
 	};
 	static int last_irq;
-	static int multiport_cnt;	/* For four-port boards w/one EEPROM */
 	int i, irq;
 	unsigned short sum;
 	unsigned char *ee_data;
@@ -1557,7 +1556,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		} else if (ee_data[0] == 0xff  &&  ee_data[1] == 0xff &&
 				   ee_data[2] == 0) {
 			sa_offset = 2;		/* Grrr, damn Matrox boards. */
-			multiport_cnt = 4;
 		}
 #ifdef CONFIG_MIPS_COBALT
                if ((pdev->bus->number == 0) &&
-- 
2.5.0

[toc] | [next] | [standalone]


#1692275

FromDavid Miller <davem@davemloft.net>
Date2017-07-20 01:40 +0200
Message-ID<u56Jr-7ff-9@gated-at.bofh.it>
In reply to#1690647
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 18 Jul 2017 15:43:33 -0500

> Remove useless local variable multiport_cnt and the code related.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web