Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692079 > unrolled thread

Re: [PATCH] mmc: core: Fix access to HS400-ES devices

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mmc: core: Fix access to HS400-ES devices Doug Anderson <dianders@chromium.org> - 2017-07-19 20:20 +0200
    Re: [PATCH] mmc: core: Fix access to HS400-ES devices Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-19 21:40 +0200

#1692079 — Re: [PATCH] mmc: core: Fix access to HS400-ES devices

Hi,

On Tue, Mar 14, 2017 at 9:22 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 1 March 2017 at 23:11, Guenter Roeck <linux@roeck-us.net> wrote:
>> HS400-ES devices fail to initialize with the following error messages.
>>
>> mmc1: power class selection to bus width 8 ddr 0 failed
>> mmc1: error -110 whilst initialising MMC card
>>
>> This was seen on Samsung Chromebook Plus. Code analysis points to
>> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
>> high-speed mode"), which attempts to set the bus width for all but
>> HS200 devices unconditionally. However, for HS400-ES, the bus width
>> is already selected.
>>
>> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Cc: Brian Norris <briannorris@chromium.org>
>> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Sorry for the delay. Been traveling.
>
> Applied for fixes, thanks!

+stable

The commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
high-speed mode") got backported to many stable branches, so probably
this commit 773dc118756b ("mmc: core: Fix access to HS400-ES devices")
also needs to get picked to the same stable branches.

In the very least v4.9 and v4.4 stable includes the broken patch but
not this fix.

-Doug

[toc] | [next] | [standalone]

#1692145

On Wed, Jul 19, 2017 at 11:12:45AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Mar 14, 2017 at 9:22 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > On 1 March 2017 at 23:11, Guenter Roeck <linux@roeck-us.net> wrote:
> >> HS400-ES devices fail to initialize with the following error messages.
> >>
> >> mmc1: power class selection to bus width 8 ddr 0 failed
> >> mmc1: error -110 whilst initialising MMC card
> >>
> >> This was seen on Samsung Chromebook Plus. Code analysis points to
> >> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> >> high-speed mode"), which attempts to set the bus width for all but
> >> HS200 devices unconditionally. However, for HS400-ES, the bus width
> >> is already selected.
> >>
> >> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> >> Cc: Douglas Anderson <dianders@chromium.org>
> >> Cc: Brian Norris <briannorris@chromium.org>
> >> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >
> > Sorry for the delay. Been traveling.
> >
> > Applied for fixes, thanks!
> 
> +stable
> 
> The commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode") got backported to many stable branches, so probably
> this commit 773dc118756b ("mmc: core: Fix access to HS400-ES devices")
> also needs to get picked to the same stable branches.
> 
> In the very least v4.9 and v4.4 stable includes the broken patch but
> not this fix.

Ah, thanks, I missed that somehow, I think I saw the fixes: field and
didn't realize that that commit was already backported.

I'll queue it up after these next kernels are released in a few days.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web