Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691895 > unrolled thread

[PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

Started byGabriel C <nix.or.die@gmail.com>
First post2017-07-19 17:40 +0200
Last post2017-07-19 21:30 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel C <nix.or.die@gmail.com> - 2017-07-19 17:40 +0200
    Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Joe Perches <joe@perches.com> - 2017-07-19 18:30 +0200
      Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel C <nix.or.die@gmail.com> - 2017-07-19 20:20 +0200
      [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel Craciunescu <nix.or.die@gmail.com> - 2017-07-19 20:30 +0200
        Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Ryan Hsu <ryanhsu@qti.qualcomm.com> - 2017-07-19 20:50 +0200
          [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg() Gabriel Craciunescu <nix.or.die@gmail.com> - 2017-07-19 21:30 +0200

#1691895 — [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

FromGabriel C <nix.or.die@gmail.com>
Date2017-07-19 17:40 +0200
Subject[PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
Message-ID<u4ZeY-222-63@gated-at.bofh.it>
         Each time we get disconencted from AP we get flooded with messages like:

         ...
         ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
         <until ratelimit kicks in>
         ath10k_warn: 155 callbacks suppressed
         ...

         Use ath10k_dbg() here too.

Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
          */

         if (!rx_status->freq) {
-               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
                 return false;
         }

-- 
2.13.3

[toc] | [next] | [standalone]

#1692009

FromJoe Perches <joe@perches.com>
Date2017-07-19 18:30 +0200
Message-ID<u501k-2Gh-21@gated-at.bofh.it>
In reply to#1691895
On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
>          Each time we get disconencted from AP we get flooded with messages like:
> 
>          ...
>          ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
>          <until ratelimit kicks in>
>          ath10k_warn: 155 callbacks suppressed

[]

> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
[]
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>           */
> 
>          if (!rx_status->freq) {
> -               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>                  return false;
>          }

Hi.  This doesn't apply because of tab to space conversions.

Please use git send-email to send your patch.

Maybe read Documentation/process/email-clients.rst

[toc] | [prev] | [next] | [standalone]

#1692081

FromGabriel C <nix.or.die@gmail.com>
Date2017-07-19 20:20 +0200
Message-ID<u51JM-3Ue-13@gated-at.bofh.it>
In reply to#1692009
On 19.07.2017 18:26, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
>>           Each time we get disconencted from AP we get flooded with messages like:
>>
>>           ...
>>           ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
>>           <until ratelimit kicks in>
>>           ath10k_warn: 155 callbacks suppressed
> 
> []
> 
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> []
>> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>>            */
>>
>>           if (!rx_status->freq) {
>> -               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
>> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>>                   return false;
>>           }
> 
> Hi.  This doesn't apply because of tab to space conversions.
> 
> Please use git send-email to send your patch.

Yes you are right .. I think newer thunderbird just doesn't work anymore to send patches.

Will have a look to setup git send-email and resend.

> 
> Maybe read Documentation/process/email-clients.rst
> 

I use tbird to send patches forver but it seems latest updates here broke it some sort.

[toc] | [prev] | [next] | [standalone]

#1692088

FromGabriel Craciunescu <nix.or.die@gmail.com>
Date2017-07-19 20:30 +0200
Message-ID<u51Ts-3Yc-25@gated-at.bofh.it>
In reply to#1692009
From: Gabriel Craciunescu <nix.or.die@gmail.com>

	Each time we get disconencted from AP we get flooded with messages like:

	...
	ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
	<until ratelimit kicks in>
	ath10k_warn: 155 callbacks suppressed
	...

	Use ath10k_dbg() here too.

Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
 drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
 	 */
 
 	if (!rx_status->freq) {
-		ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+		ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
 		return false;
 	}
 
-- 
2.13.3

[toc] | [prev] | [next] | [standalone]

#1692103

FromRyan Hsu <ryanhsu@qti.qualcomm.com>
Date2017-07-19 20:50 +0200
Message-ID<u52cO-47Q-9@gated-at.bofh.it>
In reply to#1692088
On 07/19/2017 11:24 AM, Gabriel Craciunescu wrote:

To make it consistent, maybe rename the patch title starting with ath10k:

> From: Gabriel Craciunescu <nix.or.die@gmail.com>
>
> 	Each time we get disconencted from AP we get flooded with messages like:
>
> 	...
> 	ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
> 	<until ratelimit kicks in>
> 	ath10k_warn: 155 callbacks suppressed
> 	...
>
> 	Use ath10k_dbg() here too.

You don't need an indentation on every line of the commit.

> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index 398dda978d6e..75d9b59b7e63 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>  	 */
>  
>  	if (!rx_status->freq) {
> -		ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> +		ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>  		return false;
>  	}
>  

-- 
Ryan Hsu

[toc] | [prev] | [next] | [standalone]

#1692138 — [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()

FromGabriel Craciunescu <nix.or.die@gmail.com>
Date2017-07-19 21:30 +0200
Subject[PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()
Message-ID<u52Pw-4BQ-15@gated-at.bofh.it>
In reply to#1692103
Each time we get disconencted from AP we get flooded with messages like:

...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
...

Use ath10k_dbg() here too

Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
 drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
 	 */
 
 	if (!rx_status->freq) {
-		ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+		ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
 		return false;
 	}
 
-- 
2.13.3

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web