Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690192 > unrolled thread

Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at  arch_initcall kgunda@codeaurora.org - 2017-07-18 13:50 +0200

#1690192 — Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall

On 2017-06-01 03:37, Stephen Boyd wrote:
> On 05/30, Kiran Gunda wrote:
>> @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct 
>> platform_device *pdev)
>>  		.of_match_table = spmi_pmic_arb_match_table,
>>  	},
>>  };
>> -module_platform_driver(spmi_pmic_arb_driver);
>> +
>> +int __init spmi_pmic_arb_init(void)
> 
> Missing static.
> 
>> +{
>> +	return platform_driver_register(&spmi_pmic_arb_driver);
>> +}
>> +arch_initcall(spmi_pmic_arb_init);
> 
> We also lost module removal. Probably nobody tests it, but still
> no mention of that in commit text.
> 
> I'm not sure we need this at all though. Is there something that
> needs to probe early? Indicating what that is in the commit text
> would be helpful.
Dropped out this patch. As this is no more required.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web