Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1689059 > unrolled thread
| Started by | Geert Uytterhoeven <geert+renesas@glider.be> |
|---|---|
| First post | 2017-07-17 15:50 +0200 |
| Last post | 2017-07-18 14:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata Geert Uytterhoeven <geert+renesas@glider.be> - 2017-07-17 15:50 +0200
Re: [PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata Joe Perches <joe@perches.com> - 2017-07-17 17:10 +0200
Re: [PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-18 14:30 +0200
| From | Geert Uytterhoeven <geert+renesas@glider.be> |
|---|---|
| Date | 2017-07-17 15:50 +0200 |
| Subject | [PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata |
| Message-ID | <u4ezo-5Kj-31@gated-at.bofh.it> |
As of commit bd721ea73e1f9655 ("treewide: replace obsolete _refok by
__ref"), __init_refok no longer exists, so it can be removed.
While at it, add the modern variants that were still missing.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2287a0bca863bf57..b88740bfe9d14e41 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -343,9 +343,10 @@ our $Sparse = qr{
__force|
__iomem|
__must_check|
- __init_refok|
__kprobes|
__ref|
+ __refconst|
+ __refdata|
__rcu|
__private
}x;
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-07-17 17:10 +0200 |
| Subject | Re: [PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata |
| Message-ID | <u4fOO-6GU-31@gated-at.bofh.it> |
| In reply to | #1689059 |
On Mon, 2017-07-17 at 15:42 +0200, Geert Uytterhoeven wrote:
> As of commit bd721ea73e1f9655 ("treewide: replace obsolete _refok by
> __ref"), __init_refok no longer exists, so it can be removed.
> While at it, add the modern variants that were still missing.
Maybe nicer to add some phrase like "Update sparse keywords"
in the patch title
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2287a0bca863bf57..b88740bfe9d14e41 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -343,9 +343,10 @@ our $Sparse = qr{
> __force|
> __iomem|
> __must_check|
> - __init_refok|
> __kprobes|
> __ref|
> + __refconst|
> + __refdata|
> __rcu|
> __private
> }x;
Anyway:
Acked-by: Joe Perches <joe@perches.com>
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-07-18 14:30 +0200 |
| Message-ID | <u4zNv-2nc-1@gated-at.bofh.it> |
| In reply to | #1689164 |
Hi Joe,
On Mon, Jul 17, 2017 at 5:01 PM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2017-07-17 at 15:42 +0200, Geert Uytterhoeven wrote:
>> As of commit bd721ea73e1f9655 ("treewide: replace obsolete _refok by
>> __ref"), __init_refok no longer exists, so it can be removed.
>> While at it, add the modern variants that were still missing.
>
> Maybe nicer to add some phrase like "Update sparse keywords"
> in the patch title
s/sparse/section/?
Will fix in v2.
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> scripts/checkpatch.pl | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 2287a0bca863bf57..b88740bfe9d14e41 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -343,9 +343,10 @@ our $Sparse = qr{
>> __force|
>> __iomem|
>> __must_check|
>> - __init_refok|
>> __kprobes|
>> __ref|
>> + __refconst|
>> + __refdata|
>> __rcu|
>> __private
>> }x;
>
> Anyway:
>
> Acked-by: Joe Perches <joe@perches.com>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web