Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1688550 > unrolled thread

ath10k_htt_rx_amsdu_allowed() noise

Started byGabriel C <nix.or.die@gmail.com>
First post2017-07-17 01:00 +0200
Last post2017-07-19 17:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  ath10k_htt_rx_amsdu_allowed() noise Gabriel C <nix.or.die@gmail.com> - 2017-07-17 01:00 +0200
    Re: ath10k_htt_rx_amsdu_allowed() noise Ryan Hsu <ryanhsu@qti.qualcomm.com> - 2017-07-18 09:20 +0200
      Re: ath10k_htt_rx_amsdu_allowed() noise Gabriel C <nix.or.die@gmail.com> - 2017-07-19 17:10 +0200

#1688550 — ath10k_htt_rx_amsdu_allowed() noise

FromGabriel C <nix.or.die@gmail.com>
Date2017-07-17 01:00 +0200
Subjectath10k_htt_rx_amsdu_allowed() noise
Message-ID<u40G6-58Y-19@gated-at.bofh.it>
Hello,

each time I disconnect my card from AP my dmesg gets flooded like this :

...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
<and so on>

Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?


 From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
From: Gabriel Craciunescu <nix.or.die@gmail.com>
Date: Mon, 17 Jul 2017 00:45:29 +0200
Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()

Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..ad0306cd6ee1 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
          */

         if (!rx_status->freq) {
-               ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
+               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
                 return false;
         }

-- 
2.13.3

[toc] | [next] | [standalone]


#1689801

FromRyan Hsu <ryanhsu@qti.qualcomm.com>
Date2017-07-18 09:20 +0200
Message-ID<u4uXw-7P3-21@gated-at.bofh.it>
In reply to#1688550
On 07/16/2017 03:56 PM, Gabriel C wrote:

>
> Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?
>

Looks good to me.

>
> From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
> From: Gabriel Craciunescu <nix.or.die@gmail.com>
> Date: Mon, 17 Jul 2017 00:45:29 +0200
> Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()
>
> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index 398dda978d6e..ad0306cd6ee1 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>          */
>
>         if (!rx_status->freq) {
> -               ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
>                 return false;
>         }
>

Can you send this as patch for reviewing, please?

-- 
Ryan Hsu

[toc] | [prev] | [next] | [standalone]


#1691825

FromGabriel C <nix.or.die@gmail.com>
Date2017-07-19 17:10 +0200
Message-ID<u4YLU-1Q5-5@gated-at.bofh.it>
In reply to#1689801
On 18.07.2017 09:14, Ryan Hsu wrote:
> On 07/16/2017 03:56 PM, Gabriel C wrote:
> 
>>
>> Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?
>>
> 
> Looks good to me.
> 
>>
>>  From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
>> From: Gabriel Craciunescu <nix.or.die@gmail.com>
>> Date: Mon, 17 Jul 2017 00:45:29 +0200
>> Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()
>>
>> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
>> ---
>>   drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> index 398dda978d6e..ad0306cd6ee1 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>>           */
>>
>>          if (!rx_status->freq) {
>> -               ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
>> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
>>                  return false;
>>          }
>>
> 
> Can you send this as patch for reviewing, please?
> 

Sure .. I'll try to send the patch to the list later on today..

Regards,

Gabriel C

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web