Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689634 > unrolled thread

[PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

Started bySuman Anna <s-anna@ti.com>
First post2017-07-18 05:30 +0200
Last post2017-07-19 17:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol Suman Anna <s-anna@ti.com> - 2017-07-18 05:30 +0200
    Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support  TI-SCI protocol "Andrew F. Davis" <afd@ti.com> - 2017-07-18 17:10 +0200
      Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support  TI-SCI protocol Suman Anna <s-anna@ti.com> - 2017-07-19 02:00 +0200
        Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support  TI-SCI protocol "Andrew F. Davis" <afd@ti.com> - 2017-07-19 17:30 +0200

#1689634 — [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

FromSuman Anna <s-anna@ti.com>
Date2017-07-18 05:30 +0200
Subject[PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol
Message-ID<u4rmV-5vl-17@gated-at.bofh.it>
From: Nishanth Menon <nm@ti.com>

Texas Instrument's System Control Interface (TI-SCI) Message Protocol
is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.

Add the ti-sci node representing this 66AK2G PMMC module.

Signed-off-by: Nishanth Menon <nm@ti.com>
[s-anna@ti.com: add unit address to DT node]
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index a789f75a1ed5..7f0f4180b373 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -139,5 +139,19 @@
 			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		pmmc: pmmc@02921c00 {
+			compatible = "ti,k2g-sci";
+			/*
+			 * In case of rare platforms that does not use k2g as
+			 * system master, use /delete-property/
+			 */
+			ti,system-reboot-controller;
+			mbox-names = "rx", "tx";
+			mboxes= <&msgmgr 5 2>,
+				<&msgmgr 0 0>;
+			reg-names = "debug_messages";
+			reg = <0x02921c00 0x400>;
+		};
 	};
 };
-- 
2.13.1

[toc] | [next] | [standalone]


#1690362 — Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

From"Andrew F. Davis" <afd@ti.com>
Date2017-07-18 17:10 +0200
SubjectRe: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol
Message-ID<u4Cin-3Yt-53@gated-at.bofh.it>
In reply to#1689634
On 07/17/2017 10:28 PM, Suman Anna wrote:
> From: Nishanth Menon <nm@ti.com>
> 
> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
> 
> Add the ti-sci node representing this 66AK2G PMMC module.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> [s-anna@ti.com: add unit address to DT node]
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
> index a789f75a1ed5..7f0f4180b373 100644
> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
> @@ -139,5 +139,19 @@
>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>  		};
> +
> +		pmmc: pmmc@02921c00 {
> +			compatible = "ti,k2g-sci";
> +			/*
> +			 * In case of rare platforms that does not use k2g as
> +			 * system master, use /delete-property/
> +			 */

This comment seems mis-worded, I believe this was meant to say "for
platforms that do not use the *PMMC* as the system master".

Andrew

> +			ti,system-reboot-controller;
> +			mbox-names = "rx", "tx";
> +			mboxes= <&msgmgr 5 2>,
> +				<&msgmgr 0 0>;
> +			reg-names = "debug_messages";
> +			reg = <0x02921c00 0x400>;
> +		};
>  	};
>  };
> 

[toc] | [prev] | [next] | [standalone]


#1690833 — Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

FromSuman Anna <s-anna@ti.com>
Date2017-07-19 02:00 +0200
SubjectRe: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol
Message-ID<u4Kzg-wE-3@gated-at.bofh.it>
In reply to#1690362
On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
> On 07/17/2017 10:28 PM, Suman Anna wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>
>> Add the ti-sci node representing this 66AK2G PMMC module.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> [s-anna@ti.com: add unit address to DT node]
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index a789f75a1ed5..7f0f4180b373 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -139,5 +139,19 @@
>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>  		};
>> +
>> +		pmmc: pmmc@02921c00 {
>> +			compatible = "ti,k2g-sci";
>> +			/*
>> +			 * In case of rare platforms that does not use k2g as
>> +			 * system master, use /delete-property/
>> +			 */
> 
> This comment seems mis-worded, I believe this was meant to say "for
> platforms that do not use the *PMMC* as the system master".

The comment is for the system-reboot-controller property, and is meant
to say that this property is to be deleted from this node if there is an
external entity on the board other than the K2G SoC that is responsible
for triggering a reboot.

regards
Suman

> 
> Andrew
> 
>> +			ti,system-reboot-controller;
>> +			mbox-names = "rx", "tx";
>> +			mboxes= <&msgmgr 5 2>,
>> +				<&msgmgr 0 0>;
>> +			reg-names = "debug_messages";
>> +			reg = <0x02921c00 0x400>;
>> +		};
>>  	};
>>  };
>>

[toc] | [prev] | [next] | [standalone]


#1691862 — Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

From"Andrew F. Davis" <afd@ti.com>
Date2017-07-19 17:30 +0200
SubjectRe: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol
Message-ID<u4Z5h-1XQ-61@gated-at.bofh.it>
In reply to#1690833
On 07/18/2017 06:50 PM, Suman Anna wrote:
> On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
>> On 07/17/2017 10:28 PM, Suman Anna wrote:
>>> From: Nishanth Menon <nm@ti.com>
>>>
>>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>>
>>> Add the ti-sci node representing this 66AK2G PMMC module.
>>>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> [s-anna@ti.com: add unit address to DT node]
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> index a789f75a1ed5..7f0f4180b373 100644
>>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> @@ -139,5 +139,19 @@
>>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>>  		};
>>> +
>>> +		pmmc: pmmc@02921c00 {
>>> +			compatible = "ti,k2g-sci";
>>> +			/*
>>> +			 * In case of rare platforms that does not use k2g as
>>> +			 * system master, use /delete-property/
>>> +			 */
>>
>> This comment seems mis-worded, I believe this was meant to say "for
>> platforms that do not use the *PMMC* as the system master".
> 
> The comment is for the system-reboot-controller property, and is meant
> to say that this property is to be deleted from this node if there is an
> external entity on the board other than the K2G SoC that is responsible
> for triggering a reboot.
> 

I see, that makes more sense, thanks for the clarification.

Andrew

> regards
> Suman
> 
>>
>> Andrew
>>
>>> +			ti,system-reboot-controller;
>>> +			mbox-names = "rx", "tx";
>>> +			mboxes= <&msgmgr 5 2>,
>>> +				<&msgmgr 0 0>;
>>> +			reg-names = "debug_messages";
>>> +			reg = <0x02921c00 0x400>;
>>> +		};
>>>  	};
>>>  };
>>>
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web