Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688926 > unrolled thread
| Started by | Alexandre TORGUE <alexandre.torgue@st.com> |
|---|---|
| First post | 2017-07-17 13:10 +0200 |
| Last post | 2017-07-17 13:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition Alexandre TORGUE <alexandre.torgue@st.com> - 2017-07-17 13:10 +0200
Re: [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition Arnd Bergmann <arnd@arndb.de> - 2017-07-17 13:20 +0200
Re: [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition Alexandre Torgue <alexandre.torgue@st.com> - 2017-07-17 13:30 +0200
| From | Alexandre TORGUE <alexandre.torgue@st.com> |
|---|---|
| Date | 2017-07-17 13:10 +0200 |
| Subject | [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition |
| Message-ID | <u4c4x-4fj-1@gated-at.bofh.it> |
Initially each pin was declared in "include/dt-bindings/stm32f429-pinfunc.h" and each definition contained SOC names (ex: STM32F429_PA9_FUNC_USART1_TX). Since this approach was approved, the number of supported MCU has increased (STM32F429/STM32F469/STM32f746/STM32H743). To avoid to add a new file in "include/dt-bindings" each time a new STM32 SOC arrives I propose a new approach which consist to use a macro to define pin muxing in device tree. All STM32 DT will use the common macro to define pinmux. Furthermore, it will make easy maintenance and integration of new SOC. To check that patch generate same dtb than befrore I used dtc binary to (re)generate dts files (before and after apply the series). Example on stm32f469-disco: ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-after.dts stm32f469-disco-after.dtb ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-before.dts stm32f469-disco-before.dtb Then diff -u stm32f469-disco-before.dts stm32f469-disco-after.dts Regards Alex Alexandre TORGUE (1): ARM: dts: stm32: change pinctrl bindings definition arch/arm/boot/dts/stm32f429.dtsi | 176 ++-- include/dt-bindings/pinctrl/stm32-pinfunc.h | 61 ++ include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1239 ----------------------- 3 files changed, 149 insertions(+), 1327 deletions(-) create mode 100644 include/dt-bindings/pinctrl/stm32-pinfunc.h delete mode 100644 include/dt-bindings/pinctrl/stm32f429-pinfunc.h -- 1.9.1
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-17 13:20 +0200 |
| Message-ID | <u4ced-4iB-5@gated-at.bofh.it> |
| In reply to | #1688926 |
On Mon, Jul 17, 2017 at 1:00 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:
> blabla
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
You may want to provide a little more detail here ;-)
Arnd
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Torgue <alexandre.torgue@st.com> |
|---|---|
| Date | 2017-07-17 13:30 +0200 |
| Message-ID | <u4cnU-4lE-13@gated-at.bofh.it> |
| In reply to | #1688934 |
Hi On 07/17/2017 01:15 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 1:00 PM, Alexandre TORGUE > <alexandre.torgue@st.com> wrote: >> blabla >> >> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com> > > You may want to provide a little more detail here ;-) > Oh!! Sorry, I changed it but no sent the good commit :). Please translate blablable by: Initially each pin was declared in "include/dt-bindings/stm32f429-pinfunc.h"and each definition contained SOC names (ex: STM32F429_PA9_FUNC_USART1_TX). Since this approach was approved, the number of supported MCU has increased (STM32F429/STM32F469/STM32f746/STM32H743). To avoid to add a new file in "include/dt-bindings" each time a new STM32 SOC arrives I propose a new approach which consist to use a macro to define pin muxing in device tree. All STM32 will use the common macro to define pinmux. Furthermore, it will make easy maintenance and integration of new SOC. Regards Alex > Arnd >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web