Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688860 > unrolled thread

[PATCH v2 0/5] ACPI / boot: Few amendments

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/5] ACPI / boot: Few amendments Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-17 12:30 +0200
    [PATCH v2 4/5] ACPI / boot: Not all platform require acpi_reduced_hw_init() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-17 12:30 +0200
    [PATCH v2 3/5] ACPI / boot: Add number of legacy IRQs to debug output Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-17 12:30 +0200
    Re: [PATCH v2 0/5] ACPI / boot: Few amendments "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-17 14:00 +0200
      Re: [PATCH v2 0/5] ACPI / boot: Few amendments Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-17 15:40 +0200

#1688860 — [PATCH v2 0/5] ACPI / boot: Few amendments

This series does few amendments to architectural ACPI code related to
boot, in particularly to arch/x86/kernel/acpi/boot.c.

First two patches are amendments to satisfy compiler and static analyzer
(the order is changed from first version which had been applied; in case
of partial update first patch is already in tree).

Third patch might be useful on platforms when debugging *PIC related
code path to see how many legacy IRQs are registered.

Fourth and fifth patches are preparation for some interesting
implementation of ACPI HW reduced platforms (note, this does not mean
it's against specification, patch 5 actually about following
specification).

Fifth patch might be subject to additional discussions.

In v2:
- fix function declarations in ia64 and arm64 as well (Hanjun)
- add three more patches

Andy Shevchenko (5):
  ACPI / boot: Don't define unused variables
  ACPI / boot: Correct address space of __acpi_map_table()
  ACPI / boot: Add number of legacy IRQs to debug output
  ACPI / boot: Not all platform require acpi_reduced_hw_init()
  ACPI / boot: Don't handle SCI on HW reduced platforms

 arch/arm64/kernel/acpi.c    |  4 ++--
 arch/ia64/kernel/acpi.c     |  4 ++--
 arch/x86/kernel/acpi/boot.c | 15 +++++++++------
 include/linux/acpi.h        |  7 +++++--
 4 files changed, 18 insertions(+), 12 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1688861 — [PATCH v2 4/5] ACPI / boot: Not all platform require acpi_reduced_hw_init()

Some platform might take care of legacy devices on theirs own.
Let's allow them to do that by exporting a weak function.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/kernel/acpi/boot.c | 2 +-
 include/linux/acpi.h        | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 0186d3bae610..71c0feae60a4 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1348,7 +1348,7 @@ static int __init dmi_ignore_irq0_timer_override(const struct dmi_system_id *d)
  *
  * We initialize the Hardware-reduced ACPI model here:
  */
-static void __init acpi_reduced_hw_init(void)
+void __init __weak acpi_reduced_hw_init(void)
 {
 	if (acpi_gbl_reduced_hardware) {
 		/*
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 3848b56fcd83..3ef30a7b5444 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -230,6 +230,8 @@ struct acpi_subtable_proc {
 
 void __iomem *__acpi_map_table(unsigned long phys_addr, unsigned long size);
 void __acpi_unmap_table(void __iomem *map, unsigned long size);
+
+void acpi_reduced_hw_init(void);
 int early_acpi_boot_init(void);
 int acpi_boot_init (void);
 void acpi_boot_table_init (void);
@@ -682,6 +684,7 @@ static inline struct device *acpi_get_first_physical_node(struct acpi_device *ad
 static inline void acpi_early_init(void) { }
 static inline void acpi_subsystem_init(void) { }
 
+static inline void acpi_reduced_hw_init(void) { }
 static inline int early_acpi_boot_init(void)
 {
 	return 0;
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1688863 — [PATCH v2 3/5] ACPI / boot: Add number of legacy IRQs to debug output

Sometimes it's useful to have when mp_config_acpi_legacy_irqs() is called.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/kernel/acpi/boot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 6d5b1346268a..0186d3bae610 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1078,7 +1078,7 @@ static void __init mp_config_acpi_legacy_irqs(void)
 	mp_bus_id_to_type[MP_ISA_BUS] = MP_BUS_ISA;
 #endif
 	set_bit(MP_ISA_BUS, mp_bus_not_pci);
-	pr_debug("Bus #%d is ISA\n", MP_ISA_BUS);
+	pr_debug("Bus #%d is ISA (nIRQs: %d)\n", MP_ISA_BUS, nr_legacy_irqs());
 
 	/*
 	 * Use the default configuration for the IRQs 0-15.  Unless
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1688957

On Monday, July 17, 2017 01:23:59 PM Andy Shevchenko wrote:
> This series does few amendments to architectural ACPI code related to
> boot, in particularly to arch/x86/kernel/acpi/boot.c.
> 
> First two patches are amendments to satisfy compiler and static analyzer
> (the order is changed from first version which had been applied; in case
> of partial update first patch is already in tree).
> 
> Third patch might be useful on platforms when debugging *PIC related
> code path to see how many legacy IRQs are registered.
> 
> Fourth and fifth patches are preparation for some interesting
> implementation of ACPI HW reduced platforms (note, this does not mean
> it's against specification, patch 5 actually about following
> specification).
> 
> Fifth patch might be subject to additional discussions.
> 
> In v2:
> - fix function declarations in ia64 and arm64 as well (Hanjun)
> - add three more patches
> 
> Andy Shevchenko (5):
>   ACPI / boot: Don't define unused variables
>   ACPI / boot: Correct address space of __acpi_map_table()
>   ACPI / boot: Add number of legacy IRQs to debug output
>   ACPI / boot: Not all platform require acpi_reduced_hw_init()
>   ACPI / boot: Don't handle SCI on HW reduced platforms
> 
>  arch/arm64/kernel/acpi.c    |  4 ++--
>  arch/ia64/kernel/acpi.c     |  4 ++--
>  arch/x86/kernel/acpi/boot.c | 15 +++++++++------
>  include/linux/acpi.h        |  7 +++++--
>  4 files changed, 18 insertions(+), 12 deletions(-)

Can you please CC ACPI material to linux-acpi too?

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1689046

On Mon, 2017-07-17 at 13:50 +0200, Rafael J. Wysocki wrote:
> On Monday, July 17, 2017 01:23:59 PM Andy Shevchenko wrote:
> > 
> Can you please CC ACPI material to linux-acpi too?
> 

Done.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web