Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688922 > unrolled thread

Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and  Cherry Trail CRC variants Lee Jones <lee.jones@linaro.org> - 2017-07-17 13:00 +0200
    Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and  Cherry Trail CRC variants Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-17 15:30 +0200
      Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and  Cherry Trail CRC variants Lee Jones <lee.jones@linaro.org> - 2017-07-18 09:20 +0200

#1688922 — Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants

On Sat, 01 Jul 2017, Hans de Goede wrote:

> Both Bay and Cherry Trail devices may be used together with a Crystal Cove
> PMIC. Each platform has its own variant of the PMIC, which both use the
> same ACPI HID, but they are not 100% compatible.
> 
> This commits makes the intel_soc_pmic_core code check the _HRV of the
> ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp.
> intel_soc_pmic_config_cht_crc based on this.
> 
> This fixes the Bay Trail specific ACPI OpRegion code causing problems
> on Cherry Trail devices. Specifically this was causing the external
> microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not work
> and the eMMC to become unreliable and throw lots of errors.
> 
> Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru>

Real names only please.

What is the name of this reporter/tester?

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/mfd/Kconfig               |  4 ++--
>  drivers/mfd/intel_soc_pmic_core.c | 34 ++++++++++++++++++++++++++++------
>  2 files changed, 30 insertions(+), 8 deletions(-)

Code looks okay though:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
  
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1689034

On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote:
> On Sat, 01 Jul 2017, Hans de Goede wrote:
> 
> > Both Bay and Cherry Trail devices may be used together with a
> > Crystal Cove
> > PMIC. Each platform has its own variant of the PMIC, which both use
> > the
> > same ACPI HID, but they are not 100% compatible.
> > 
> > This commits makes the intel_soc_pmic_core code check the _HRV of
> > the
> > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp.
> > intel_soc_pmic_config_cht_crc based on this.
> > 
> > This fixes the Bay Trail specific ACPI OpRegion code causing
> > problems
> > on Cherry Trail devices. Specifically this was causing the external
> > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not
> > work
> > and the eMMC to become unreliable and throw lots of errors.
> > 
> > Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru
> > >
> 
> Real names only please.
> 
> What is the name of this reporter/tester?

No one knows, I think.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1689800

On Mon, 17 Jul 2017, Andy Shevchenko wrote:

> On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote:
> > On Sat, 01 Jul 2017, Hans de Goede wrote:
> > 
> > > Both Bay and Cherry Trail devices may be used together with a
> > > Crystal Cove
> > > PMIC. Each platform has its own variant of the PMIC, which both use
> > > the
> > > same ACPI HID, but they are not 100% compatible.
> > > 
> > > This commits makes the intel_soc_pmic_core code check the _HRV of
> > > the
> > > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp.
> > > intel_soc_pmic_config_cht_crc based on this.
> > > 
> > > This fixes the Bay Trail specific ACPI OpRegion code causing
> > > problems
> > > on Cherry Trail devices. Specifically this was causing the external
> > > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not
> > > work
> > > and the eMMC to become unreliable and throw lots of errors.
> > > 
> > > Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru
> > > >
> > 
> > Real names only please.
> > 
> > What is the name of this reporter/tester?
> 
> No one knows, I think.

Then I don't think we can credit him/her for their efforts.
SubmittingPatches clearly states "no pseudonyms or anonymous
contributions".  Either write to them and ask for their real name so
that they can be credited, or remove the line.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web