Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688815 > unrolled thread
| Started by | Michal Simek <michal.simek@xilinx.com> |
|---|---|
| First post | 2017-07-17 11:30 +0200 |
| Last post | 2017-07-18 11:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 Michal Simek <michal.simek@xilinx.com> - 2017-07-17 11:30 +0200
Re: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:10 +0200
| From | Michal Simek <michal.simek@xilinx.com> |
|---|---|
| Date | 2017-07-17 11:30 +0200 |
| Subject | [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 |
| Message-ID | <u4avN-3bA-19@gated-at.bofh.it> |
MTF_CORE should be enabled when driver is enabled. Without this patch you can configure: CONFIG_MFD_CORE is not set CONFIG_MFD_TPS65086=y which ends up with compilation error: drivers/mfd/tps65086.o: In function `tps65086_probe': drivers/mfd/tps65086.c:110: undefined reference to `mfd_add_devices' drivers/mfd/tps65086.c:110:(.text+0x128): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mfd_add_devices' Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Changes in v2: - Update commit message based on discussion with Lee Jones drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 94ad2c1c3d90..f98b5a6d4da8 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1294,6 +1294,7 @@ config TPS6507X config MFD_TPS65086 tristate "TI TPS65086 Power Management Integrated Chips (PMICs)" + select MFD_CORE select REGMAP select REGMAP_IRQ select REGMAP_I2C -- 1.9.1
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-07-18 11:10 +0200 |
| Message-ID | <u4wFX-sD-3@gated-at.bofh.it> |
| In reply to | #1688815 |
On Mon, 17 Jul 2017, Michal Simek wrote: > MTF_CORE should be enabled when driver is enabled. > > Without this patch you can configure: > CONFIG_MFD_CORE is not set > CONFIG_MFD_TPS65086=y > > which ends up with compilation error: > drivers/mfd/tps65086.o: In function `tps65086_probe': > drivers/mfd/tps65086.c:110: undefined reference to > `mfd_add_devices' > drivers/mfd/tps65086.c:110:(.text+0x128): relocation > truncated to fit: R_AARCH64_CALL26 against undefined symbol > `mfd_add_devices' > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: > - Update commit message based on discussion with Lee Jones > > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 94ad2c1c3d90..f98b5a6d4da8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1294,6 +1294,7 @@ config TPS6507X > > config MFD_TPS65086 > tristate "TI TPS65086 Power Management Integrated Chips (PMICs)" > + select MFD_CORE > select REGMAP > select REGMAP_IRQ > select REGMAP_I2C -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web