Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691882 > unrolled thread

Re: [PATCH 6/6] cgroup: update debug controller to print out thread mode information

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 6/6] cgroup: update debug controller to print out thread  mode information Tejun Heo <tj@kernel.org> - 2017-07-19 17:40 +0200
    Re: [PATCH 6/6] cgroup: update debug controller to print out thread  mode information Waiman Long <longman@redhat.com> - 2017-07-19 17:50 +0200
      Re: [PATCH 6/6] cgroup: update debug controller to print out thread  mode information Tejun Heo <tj@kernel.org> - 2017-07-19 17:50 +0200

#1691882 — Re: [PATCH 6/6] cgroup: update debug controller to print out thread mode information

Hello,

On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote:
> > +	if (cgroup_is_thread_root(css->cgroup))
> > +		seq_puts(seq, "[thread root]\n");
> > +	else if (cgroup_is_threaded(css->cgroup))
> > +		seq_puts(seq, "[threaded]\n");
> 
> The cgroup status will not be needed anymore as you have introduced the
> cgroup.type control file that returns the proper information.

Ah, right, will drop this file.

Thanks.

-- 
tejun

[toc] | [next] | [standalone]

#1691917

On 07/19/2017 11:31 AM, Tejun Heo wrote:
> Hello,
>
> On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote:
>>> +	if (cgroup_is_thread_root(css->cgroup))
>>> +		seq_puts(seq, "[thread root]\n");
>>> +	else if (cgroup_is_threaded(css->cgroup))
>>> +		seq_puts(seq, "[threaded]\n");
>> The cgroup status will not be needed anymore as you have introduced the
>> cgroup.type control file that returns the proper information.
> Ah, right, will drop this file.
>
> Thanks.
>
Oh, I am not saying that we should drop the whole patch. I just want to
drop the above 4 line of codes as they are not needed.

Thanks,
Longman

[toc] | [prev] | [next] | [standalone]

#1691940

On Wed, Jul 19, 2017 at 11:41:09AM -0400, Waiman Long wrote:
> On 07/19/2017 11:31 AM, Tejun Heo wrote:
> > Hello,
> >
> > On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote:
> >>> +	if (cgroup_is_thread_root(css->cgroup))
> >>> +		seq_puts(seq, "[thread root]\n");
> >>> +	else if (cgroup_is_threaded(css->cgroup))
> >>> +		seq_puts(seq, "[threaded]\n");
> >> The cgroup status will not be needed anymore as you have introduced the
> >> cgroup.type control file that returns the proper information.
> > Ah, right, will drop this file.
> >
> > Thanks.
> >
> Oh, I am not saying that we should drop the whole patch. I just want to
> drop the above 4 line of codes as they are not needed.

lol, yeah, that's me mis-writing.  I'm gonna drop only the duplicate
part.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web