Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1691855 > unrolled thread
| Started by | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| First post | 2017-07-19 17:30 +0200 |
| Last post | 2017-07-27 21:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-19 17:30 +0200
Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control Moritz Fischer <mdf@kernel.org> - 2017-07-19 18:20 +0200
Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control Alan Tull <atull@kernel.org> - 2017-07-27 21:00 +0200
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2017-07-19 17:30 +0200 |
| Subject | [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control |
| Message-ID | <u4Z5g-1XQ-43@gated-at.bofh.it> |
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: linux-fpga@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/fpga/altera-hps2fpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
index 3066b805f2d07..a18ff430c9af1 100644
--- a/drivers/fpga/altera-hps2fpga.c
+++ b/drivers/fpga/altera-hps2fpga.c
@@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
of_id = of_match_device(altera_fpga_of_match, dev);
priv = (struct altera_hps2fpga_data *)of_id->data;
- priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
+ priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
+ 0);
if (IS_ERR(priv->bridge_reset)) {
dev_err(dev, "Could not get %s reset control\n", priv->name);
return PTR_ERR(priv->bridge_reset);
--
2.11.0
[toc] | [next] | [standalone]
| From | Moritz Fischer <mdf@kernel.org> |
|---|---|
| Date | 2017-07-19 18:20 +0200 |
| Subject | Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control |
| Message-ID | <u4ZRD-2BD-19@gated-at.bofh.it> |
| In reply to | #1691855 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: linux-fpga@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-By: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/altera-hps2fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b805f2d07..a18ff430c9af1 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> of_id = of_match_device(altera_fpga_of_match, dev);
> priv = (struct altera_hps2fpga_data *)of_id->data;
>
> - priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> + priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> + 0);
> if (IS_ERR(priv->bridge_reset)) {
> dev_err(dev, "Could not get %s reset control\n", priv->name);
> return PTR_ERR(priv->bridge_reset);
> --
> 2.11.0
>
Thanks,
Moritz
[toc] | [prev] | [next] | [standalone]
| From | Alan Tull <atull@kernel.org> |
|---|---|
| Date | 2017-07-27 21:00 +0200 |
| Message-ID | <u7WaS-1i7-7@gated-at.bofh.it> |
| In reply to | #1692001 |
On Wed, Jul 19, 2017 at 11:12 AM, Moritz Fischer <mdf@kernel.org> wrote:
> On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Acked-By: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web