Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1691060 > unrolled thread

Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

Started bySuganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
First post2017-07-19 09:30 +0200
Last post2017-07-19 09:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128 Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com> - 2017-07-19 09:30 +0200

#1691060 — Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

FromSuganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Date2017-07-19 09:30 +0200
SubjectRe: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128
Message-ID<u4RAJ-5hK-13@gated-at.bofh.it>
Hi Elliott,
We are maintaining NVMe drives as scsi device in mpt3sas driver.
There are lot of firmware/hardware level dependencies and after lot of
discussions we arrived this value (128).
So, we prefer not to provide module parameter to change this at least for now.

Thanks,
Suganath Prabu S

On Tue, Jul 11, 2017 at 10:53 PM, Elliott, Robert (Persistent Memory)
<elliott@hpe.com> wrote:
>> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h
>> @@ -115,7 +115,7 @@
>>
>>  #define MPT3SAS_RAID_MAX_SECTORS     8192
>>  #define MPT3SAS_HOST_PAGE_SIZE_4K    12
>> -
>> +#define MPT3SAS_NVME_QUEUE_DEPTH     128
> ...
>> +             /*TODO-right Queue Depth?*/
>> +             qdepth = MPT3SAS_NVME_QUEUE_DEPTH;
>> +             ds = "NVMe";
>
> The native NVMe driver is getting a modparam to set that value (rather than
> using a #define of 1024) in this patch:
>         http://lists.infradead.org/pipermail/linux-nvme/2017-July/011734.html
>
> Perhaps this driver should do the same.
>
> ---
> Robert Elliott, HPE Persistent Memory
>
>

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web