Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690703 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2017-07-18 23:50 +0200 |
| Last post | 2017-07-19 16:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] fpga: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-07-18 23:50 +0200
Re: [PATCH] fpga: Convert to using %pOF instead of full_name Moritz Fischer <mdf@kernel.org> - 2017-07-19 06:50 +0200
Re: [PATCH] fpga: Convert to using %pOF instead of full_name Alan Tull <atull@kernel.org> - 2017-07-19 16:40 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-07-18 23:50 +0200 |
| Subject | [PATCH] fpga: Convert to using %pOF instead of full_name |
| Message-ID | <u4Ixt-7K6-55@gated-at.bofh.it> |
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: linux-fpga@vger.kernel.org
---
drivers/fpga/fpga-region.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index 3b6b2f4182a1..d9ab7c75b14f 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
of_node_put(child_region);
if (ret)
- pr_err("firmware-name not allowed in child FPGA region: %s",
- child_region->full_name);
+ pr_err("firmware-name not allowed in child FPGA region: %pOF",
+ child_region);
return ret;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Moritz Fischer <mdf@kernel.org> |
|---|---|
| Date | 2017-07-19 06:50 +0200 |
| Message-ID | <u4P5T-3vt-3@gated-at.bofh.it> |
| In reply to | #1690703 |
On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: linux-fpga@vger.kernel.org
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/fpga-region.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index 3b6b2f4182a1..d9ab7c75b14f 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
> of_node_put(child_region);
>
> if (ret)
> - pr_err("firmware-name not allowed in child FPGA region: %s",
> - child_region->full_name);
> + pr_err("firmware-name not allowed in child FPGA region: %pOF",
> + child_region);
>
> return ret;
> }
> --
> 2.11.0
>
[toc] | [prev] | [next] | [standalone]
| From | Alan Tull <atull@kernel.org> |
|---|---|
| Date | 2017-07-19 16:40 +0200 |
| Message-ID | <u4YiV-1nV-109@gated-at.bofh.it> |
| In reply to | #1690964 |
On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
> Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
>> ---
>> drivers/fpga/fpga-region.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
>> index 3b6b2f4182a1..d9ab7c75b14f 100644
>> --- a/drivers/fpga/fpga-region.c
>> +++ b/drivers/fpga/fpga-region.c
>> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>> of_node_put(child_region);
>>
>> if (ret)
>> - pr_err("firmware-name not allowed in child FPGA region: %s",
>> - child_region->full_name);
>> + pr_err("firmware-name not allowed in child FPGA region: %pOF",
>> + child_region);
>>
>> return ret;
>> }
>> --
>> 2.11.0
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web