Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690892 > unrolled thread

Re: [PATCH] hwmon: i5k_amb: constify pci_device_id.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] hwmon: i5k_amb: constify pci_device_id. Guenter Roeck <linux@roeck-us.net> - 2017-07-19 03:50 +0200

#1690892 — Re: [PATCH] hwmon: i5k_amb: constify pci_device_id.

On 07/17/2017 09:25 AM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     3562	    320	      8	   3890	    f32	drivers/hwmon/i5k_amb.o
> 
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>     3658	    224	      8	   3890	    f32	drivers/hwmon/i5k_amb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>   drivers/hwmon/i5k_amb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
> index a5a9f45..9397d2f 100644
> --- a/drivers/hwmon/i5k_amb.c
> +++ b/drivers/hwmon/i5k_amb.c
> @@ -495,7 +495,7 @@ static struct {
>   };
>   
>   #ifdef MODULE
> -static struct pci_device_id i5k_amb_ids[] = {
> +static const struct pci_device_id i5k_amb_ids[] = {
>   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
>   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
>   	{ 0, }
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web