Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690691 > unrolled thread

[PATCH] extcon: Convert to using %pOF instead of full_name

Back to article view | Back to linux.kernel

Contents

  [PATCH] extcon: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-07-18 23:50 +0200
    Re: [PATCH] extcon: Convert to using %pOF instead of full_name Chanwoo Choi <cw00.choi@samsung.com> - 2017-07-19 03:40 +0200

#1690691 — [PATCH] extcon: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/extcon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 8eccf7b14937..229364a9d868 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1363,8 +1363,8 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)

 	node = of_parse_phandle(dev->of_node, "extcon", index);
 	if (!node) {
-		dev_dbg(dev, "failed to get phandle in %s node\n",
-			dev->of_node->full_name);
+		dev_dbg(dev, "failed to get phandle in %pOF node\n",
+			dev->of_node);
 		return ERR_PTR(-ENODEV);
 	}

--
2.11.0

[toc] | [next] | [standalone]

#1690881

Hi,

On 2017년 07월 19일 06:43, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/extcon/extcon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 8eccf7b14937..229364a9d868 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1363,8 +1363,8 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
> 
>  	node = of_parse_phandle(dev->of_node, "extcon", index);
>  	if (!node) {
> -		dev_dbg(dev, "failed to get phandle in %s node\n",
> -			dev->of_node->full_name);
> +		dev_dbg(dev, "failed to get phandle in %pOF node\n",
> +			dev->of_node);
>  		return ERR_PTR(-ENODEV);
>  	}

Applied it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web