Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690725 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2017-07-19 00:00 +0200 |
| Last post | 2017-07-21 10:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / Domains: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-07-19 00:00 +0200
Re: [PATCH] PM / Domains: Convert to using %pOF instead of full_name Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-19 11:20 +0200
Re: [PATCH] PM / Domains: Convert to using %pOF instead of full_name Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-21 10:00 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-07-19 00:00 +0200 |
| Subject | [PATCH] PM / Domains: Convert to using %pOF instead of full_name |
| Message-ID | <u4IH9-7NO-33@gated-at.bofh.it> |
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-pm@vger.kernel.org
---
drivers/base/power/domain.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 3b8210ebb50e..d0989f9b5e67 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1743,7 +1743,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate,
mutex_lock(&of_genpd_mutex);
list_add(&cp->link, &of_genpd_providers);
mutex_unlock(&of_genpd_mutex);
- pr_debug("Added domain provider from %s\n", np->full_name);
+ pr_debug("Added domain provider from %pOF\n", np);
return 0;
}
@@ -2149,16 +2149,16 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
err = of_property_read_u32(state_node, "entry-latency-us",
&entry_latency);
if (err) {
- pr_debug(" * %s missing entry-latency-us property\n",
- state_node->full_name);
+ pr_debug(" * %pOF missing entry-latency-us property\n",
+ state_node);
return -EINVAL;
}
err = of_property_read_u32(state_node, "exit-latency-us",
&exit_latency);
if (err) {
- pr_debug(" * %s missing exit-latency-us property\n",
- state_node->full_name);
+ pr_debug(" * %pOF missing exit-latency-us property\n",
+ state_node);
return -EINVAL;
}
@@ -2212,8 +2212,8 @@ int of_genpd_parse_idle_states(struct device_node *dn,
ret = genpd_parse_state(&st[i++], np);
if (ret) {
pr_err
- ("Parsing idle state node %s failed with err %d\n",
- np->full_name, ret);
+ ("Parsing idle state node %pOF failed with err %d\n",
+ np, ret);
of_node_put(np);
kfree(st);
return ret;
--
2.11.0
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-07-19 11:20 +0200 |
| Message-ID | <u4Tjc-6v5-17@gated-at.bofh.it> |
| In reply to | #1690725 |
On Tue, Jul 18, 2017 at 11:42 PM, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-07-21 10:00 +0200 |
| Message-ID | <u5B0S-1Xy-17@gated-at.bofh.it> |
| In reply to | #1690725 |
On 18 July 2017 at 23:42, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-pm@vger.kernel.org
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/base/power/domain.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 3b8210ebb50e..d0989f9b5e67 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1743,7 +1743,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate,
> mutex_lock(&of_genpd_mutex);
> list_add(&cp->link, &of_genpd_providers);
> mutex_unlock(&of_genpd_mutex);
> - pr_debug("Added domain provider from %s\n", np->full_name);
> + pr_debug("Added domain provider from %pOF\n", np);
>
> return 0;
> }
> @@ -2149,16 +2149,16 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
> err = of_property_read_u32(state_node, "entry-latency-us",
> &entry_latency);
> if (err) {
> - pr_debug(" * %s missing entry-latency-us property\n",
> - state_node->full_name);
> + pr_debug(" * %pOF missing entry-latency-us property\n",
> + state_node);
> return -EINVAL;
> }
>
> err = of_property_read_u32(state_node, "exit-latency-us",
> &exit_latency);
> if (err) {
> - pr_debug(" * %s missing exit-latency-us property\n",
> - state_node->full_name);
> + pr_debug(" * %pOF missing exit-latency-us property\n",
> + state_node);
> return -EINVAL;
> }
>
> @@ -2212,8 +2212,8 @@ int of_genpd_parse_idle_states(struct device_node *dn,
> ret = genpd_parse_state(&st[i++], np);
> if (ret) {
> pr_err
> - ("Parsing idle state node %s failed with err %d\n",
> - np->full_name, ret);
> + ("Parsing idle state node %pOF failed with err %d\n",
> + np, ret);
> of_node_put(np);
> kfree(st);
> return ret;
> --
> 2.11.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web