Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690649 > unrolled thread
| Started by | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| First post | 2017-07-18 23:10 +0200 |
| Last post | 2017-07-20 01:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] rtlwifi: remove useless code "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-18 23:10 +0200
Re: [PATCH] rtlwifi: remove useless code Larry Finger <Larry.Finger@lwfinger.net> - 2017-07-19 03:40 +0200
Re: [PATCH] rtlwifi: remove useless code David Miller <davem@davemloft.net> - 2017-07-20 01:40 +0200
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-07-18 23:10 +0200 |
| Subject | [PATCH] rtlwifi: remove useless code |
| Message-ID | <u4HUJ-7vU-11@gated-at.bofh.it> |
Remove useless local variables last_read_point and last_txw_point and
the code related.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
index 55f238a..c58393e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
@@ -478,7 +478,6 @@ u16 rtl92ee_rx_desc_buff_remained_cnt(struct ieee80211_hw *hw, u8 queue_index)
struct rtl_priv *rtlpriv = rtl_priv(hw);
u16 read_point = 0, write_point = 0, remind_cnt = 0;
u32 tmp_4byte = 0;
- static u16 last_read_point;
static bool start_rx;
tmp_4byte = rtl_read_dword(rtlpriv, REG_RXQ_TXBD_IDX);
@@ -506,7 +505,6 @@ u16 rtl92ee_rx_desc_buff_remained_cnt(struct ieee80211_hw *hw, u8 queue_index)
rtlpci->rx_ring[queue_index].next_rx_rp = write_point;
- last_read_point = read_point;
return remind_cnt;
}
@@ -917,7 +915,6 @@ void rtl92ee_set_desc(struct ieee80211_hw *hw, u8 *pdesc, bool istx,
struct rtl_priv *rtlpriv = rtl_priv(hw);
u16 cur_tx_rp = 0;
u16 cur_tx_wp = 0;
- static u16 last_txw_point;
static bool over_run;
u32 tmp = 0;
u8 q_idx = *val;
@@ -951,9 +948,6 @@ void rtl92ee_set_desc(struct ieee80211_hw *hw, u8 *pdesc, bool istx,
rtl_write_word(rtlpriv,
get_desc_addr_fr_q_idx(q_idx),
ring->cur_tx_wp);
-
- if (q_idx == 1)
- last_txw_point = cur_tx_wp;
}
if (ring->avl_desc < (max_tx_desc - 15)) {
--
2.5.0
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-07-19 03:40 +0200 |
| Message-ID | <u4M81-1zI-13@gated-at.bofh.it> |
| In reply to | #1690649 |
On 07/18/2017 03:41 PM, Gustavo A. R. Silva wrote: > Remove useless local variables last_read_point and last_txw_point and > the code related. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 ------ > 1 file changed, 6 deletions(-) Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Thanks, Larry
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-20 01:40 +0200 |
| Message-ID | <u56Jt-7ff-41@gated-at.bofh.it> |
| In reply to | #1690649 |
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Tue, 18 Jul 2017 15:41:06 -0500 > Remove useless local variables last_read_point and last_txw_point and > the code related. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web