Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690628 > unrolled thread

Re: [PATCH net-next 0/5] refine virtio-net XDP

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH net-next 0/5] refine virtio-net XDP "Michael S. Tsirkin" <mst@redhat.com> - 2017-07-18 22:20 +0200
    Re: [PATCH net-next 0/5] refine virtio-net XDP Jason Wang <jasowang@redhat.com> - 2017-07-19 04:50 +0200

#1690628 — Re: [PATCH net-next 0/5] refine virtio-net XDP

On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote:
> Hi:
> 
> This series brings two optimizations for virtio-net XDP:
> 
> - avoid reset during XDP set
> - turn off offloads on demand

I'm glad to see this take shape - this can be
extended to optimize virtnet_get_headroom so we don't
waste room if adjust_head is enabled.

I see a couple of issues, responded to individual patches.


> Please review.
> 
> Thanks
> 
> Jason Wang (5):
>   virtio_ring: allow to store zero as the ctx
>   virtio-net: pack headroom into ctx for mergeable buffer
>   virtio-net: switch to use new ctx API for small buffer
>   virtio-net: do not reset during XDP set
>   virtio-net: switch off offloads on demand if possible on XDP set
> 
>  drivers/net/virtio_net.c     | 325 +++++++++++++++++++++++++------------------
>  drivers/virtio/virtio_ring.c |   2 +-
>  2 files changed, 194 insertions(+), 133 deletions(-)
> 
> -- 
> 2.7.4

[toc] | [next] | [standalone]

#1690921

On 2017年07月19日 04:13, Michael S. Tsirkin wrote:
> On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote:
>> Hi:
>>
>> This series brings two optimizations for virtio-net XDP:
>>
>> - avoid reset during XDP set
>> - turn off offloads on demand
> I'm glad to see this take shape - this can be
> extended to optimize virtnet_get_headroom so we don't
> waste room if adjust_head is enabled.

Right, we can do it on top.

> I see a couple of issues, responded to individual patches.
>
>

Thanks for the reviewing.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web