Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1689218 > unrolled thread
| Started by | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| First post | 2017-07-17 18:20 +0200 |
| Last post | 2017-07-18 17:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 1/1] Staging: android/ion: declare function static Joseph Wright <rjosephwright@gmail.com> - 2017-07-17 18:20 +0200
Re: [PATCH v3 1/1] Staging: android/ion: declare function static Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 09:00 +0200
Re: [PATCH v3 1/1] Staging: android/ion: declare function static Joseph Wright <rjosephwright@gmail.com> - 2017-07-18 17:10 +0200
| From | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| Date | 2017-07-17 18:20 +0200 |
| Subject | [PATCH v3 1/1] Staging: android/ion: declare function static |
| Message-ID | <u4gUx-7l9-1@gated-at.bofh.it> |
Declare private function static to fix sparse warning:
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?
Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
Changes in v3:
- Make subject clearer
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
return &cma_heap->heap;
}
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
{
struct ion_heap *heap;
--
2.9.3
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-18 09:00 +0200 |
| Message-ID | <u4uE9-7rF-1@gated-at.bofh.it> |
| In reply to | #1689218 |
On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote: > Declare private function static to fix sparse warning: > > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > was not declared. Should it be static? > > Signed-off-by: Joseph Wright <rjosephwright@gmail.com> > --- > Changes in v3: > - Make subject clearer > > drivers/staging/android/ion/ion_cma_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sorry, does not apply to my tree as I think someone else already did this before you did :(
[toc] | [prev] | [next] | [standalone]
| From | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| Date | 2017-07-18 17:10 +0200 |
| Message-ID | <u4Cil-3Yt-1@gated-at.bofh.it> |
| In reply to | #1689783 |
On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote: > On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote: > > Declare private function static to fix sparse warning: > > > > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > > was not declared. Should it be static? > > > > Signed-off-by: Joseph Wright <rjosephwright@gmail.com> > > --- > > Changes in v3: > > - Make subject clearer > > > > drivers/staging/android/ion/ion_cma_heap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Sorry, does not apply to my tree as I think someone else already did > this before you did :( Okay, thanks anyway. Joseph
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web