Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690168 > unrolled thread

[PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-18 13:30 +0200
    Re: [PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before  claiming the interrupt Greg Kroah-Hartman <greg@kroah.com> - 2017-07-18 16:30 +0200

#1690168 — [PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt

Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
---
 drivers/w1/masters/ds1wm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
index 1b37def..7cb4460 100644
--- a/drivers/w1/masters/ds1wm.c
+++ b/drivers/w1/masters/ds1wm.c
@@ -510,6 +510,7 @@ static int ds1wm_probe(struct platform_device *pdev)
 	struct ds1wm_driver_data *plat;
 	struct resource *res;
 	int ret;
+	u8 inten;
 
 	if (!pdev)
 		return -ENODEV;
@@ -563,6 +564,11 @@ static int ds1wm_probe(struct platform_device *pdev)
 	ds1wm_data->int_en_reg_none = (plat->active_high ? DS1WM_INTEN_IAS : 0);
 	ds1wm_data->reset_recover_delay = plat->reset_recover_delay;
 
+	/* Mask interrupts, set IAS before claiming interrupt */
+	inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
+	ds1wm_write_register(ds1wm_data,
+		DS1WM_INT_EN, ds1wm_data->int_en_reg_none);
+
 	if (res->flags & IORESOURCE_IRQ_HIGHEDGE)
 		irq_set_irq_type(ds1wm_data->irq, IRQ_TYPE_EDGE_RISING);
 	if (res->flags & IORESOURCE_IRQ_LOWEDGE)
-- 
2.1.4

[toc] | [next] | [standalone]

#1690314 — Re: [PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt

On Tue, Jul 18, 2017 at 01:26:52PM +0200, Johannes Poehlmann wrote:
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
>  drivers/w1/masters/ds1wm.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Same here, I need a changelog text.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web