Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1688605 > unrolled thread

Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal

Started byMichael Ellerman <mpe@ellerman.id.au>
First post2017-07-17 04:20 +0200
Last post2017-07-17 08:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal Michael Ellerman <mpe@ellerman.id.au> - 2017-07-17 04:20 +0200
    Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to  boot on ppc bare-metal Abdul Haleem <abdhalee@linux.vnet.ibm.com> - 2017-07-17 08:10 +0200

#1688605 — Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-07-17 04:20 +0200
SubjectRe: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal
Message-ID<u43ND-7p2-7@gated-at.bofh.it>
Hi Abdul,

Thanks for the bug report.

Abdul Haleem <abdhalee@linux.vnet.ibm.com> writes:
> Hi 
>
> Today's linux-next fails to boot on ppc bare-metal
>
> Test: Boot
> Machine: Power 8 bare-metal
> kernel: 4.12.0-next-20170713
> gcc: version 4.8.5
> config : Tul-NV-config attached.

[swearing redacted]

Does this help?

cheers


diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 9b87abb178f0..cad6b57ce494 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -78,7 +78,7 @@ void opal_configure_cores(void)
 	 *  ie. Host hash  supports  hash guests
 	 *      Host radix supports  hash/radix guests
 	 */
-	if (cpu_has_feature(CPU_FTR_ARCH_300)) {
+	if (early_cpu_has_feature(CPU_FTR_ARCH_300)) {
 		reinit_flags |= OPAL_REINIT_CPUS_MMU_HASH;
 		if (early_radix_enabled())
 			reinit_flags |= OPAL_REINIT_CPUS_MMU_RADIX;

[toc] | [next] | [standalone]


#1688678 — Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal

FromAbdul Haleem <abdhalee@linux.vnet.ibm.com>
Date2017-07-17 08:10 +0200
SubjectRe: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal
Message-ID<u47oe-1fK-7@gated-at.bofh.it>
In reply to#1688605
On Mon, 2017-07-17 at 12:10 +1000, Michael Ellerman wrote:
> Hi Abdul,
> 
> Thanks for the bug report.
> 
> Abdul Haleem <abdhalee@linux.vnet.ibm.com> writes:
> > Hi 
> >
> > Today's linux-next fails to boot on ppc bare-metal
> >
> > Test: Boot
> > Machine: Power 8 bare-metal
> > kernel: 4.12.0-next-20170713
> > gcc: version 4.8.5
> > config : Tul-NV-config attached.
> 
> [swearing redacted]
> 
> Does this help?

Yes, it fixes the boot issue. Thanks for the fix.

With below patch, I was able to successfully boot
4.13.0-rc1-next-20170717 kernel on ppc bare-metal

Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>

> 
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 9b87abb178f0..cad6b57ce494 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -78,7 +78,7 @@ void opal_configure_cores(void)
>  	 *  ie. Host hash  supports  hash guests
>  	 *      Host radix supports  hash/radix guests
>  	 */
> -	if (cpu_has_feature(CPU_FTR_ARCH_300)) {
> +	if (early_cpu_has_feature(CPU_FTR_ARCH_300)) {
>  		reinit_flags |= OPAL_REINIT_CPUS_MMU_HASH;
>  		if (early_radix_enabled())
>  			reinit_flags |= OPAL_REINIT_CPUS_MMU_RADIX;
> 


-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web