Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687577 > unrolled thread

Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add tracepoints for oom reaper-related events)

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-14 19:30 +0200
    Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Tony Lindgren <tony@atomide.com> - 2017-07-17 08:10 +0200
      Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 12:00 +0200
        Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Tony Lindgren <tony@atomide.com> - 2017-07-17 12:20 +0200
          Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 13:20 +0200
            Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 14:00 +0200
              Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add  tracepoints for oom reaper-related events) Tony Lindgren <tony@atomide.com> - 2017-07-18 08:10 +0200

#1687577 — Re: Droid 4 boot failure due to 422580c3cea7 (mm/oom_kill.c: add tracepoints for oom reaper-related events)

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, Jul 14, 2017 at 02:12:21PM +0000, Roman Gushchin wrote:
> > On 14 Jul 2017, at 14:43, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote:
> > I just bisected another issue breaking boot on Droid 4. My
> > bisect points to 422580c3cea7 (mm/oom_kill.c: add tracepoints
> > for oom reaper-related events). It do not see any message
> > printed to UART (with earlyprintk) once that commit is part
> > of my image. Kernel config is below.

> This is really interesting, because this patch adds few
> tracepoints and all of them are called from the oom code, which is
> hopefully not a part of the boot process.
> 
> Can you, please, confirm, that it can be reproduced with some
> confidence? If so, can you, please, eliminate the tracepoints
> calls and try to reproduce the boot failure?

I can boot 9967468c0a10 ("Merge branch 'akpm' (patches from
Andrew)") after adding

 - http://git.kernel.org/tip/19d39a3810e7032f311ef83effdac40339b9d022
   (another issue, that breaks Droid 4 boot)
 - a git revert of 422580c3cea7

OTOH there are strange problems. Using da16dd9785f8 + above
two commits also works. Using b5e16170f59b + above commits
does not work and bisection ended up in the merge commit.

-- Sebastian

[toc] | [next] | [standalone]

#1688679

* Roman Gushchin <guro@fb.com> [170716 05:55]:
> On Fri, Jul 14, 2017 at 07:23:43PM +0200, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Fri, Jul 14, 2017 at 02:12:21PM +0000, Roman Gushchin wrote:
> > > > On 14 Jul 2017, at 14:43, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote:
> > > > I just bisected another issue breaking boot on Droid 4. My
> > > > bisect points to 422580c3cea7 (mm/oom_kill.c: add tracepoints
> > > > for oom reaper-related events). It do not see any message
> > > > printed to UART (with earlyprintk) once that commit is part
> > > > of my image. Kernel config is below.
> > 
> > > This is really interesting, because this patch adds few
> > > tracepoints and all of them are called from the oom code, which is
> > > hopefully not a part of the boot process.
> > > 
> > > Can you, please, confirm, that it can be reproduced with some
> > > confidence? If so, can you, please, eliminate the tracepoints
> > > calls and try to reproduce the boot failure?
> > 
> > I can boot 9967468c0a10 ("Merge branch 'akpm' (patches from
> > Andrew)") after adding
> > 
> >  - http://git.kernel.org/tip/19d39a3810e7032f311ef83effdac40339b9d022
> >    (another issue, that breaks Droid 4 boot)
> >  - a git revert of 422580c3cea7
> > 
> > OTOH there are strange problems. Using da16dd9785f8 + above
> > two commits also works. Using b5e16170f59b + above commits
> > does not work and bisection ended up in the merge commit.
> 
> Hi, Sebastian!
> 
> As commit 422580c3cea7 hasn't added any code, which is executed
> during the boot process, I could imagine only two options:
> 1) Added code/data occasionally broke some alignment/size contraints.
> 2) There is another instable bug, which compromised bisect results.
> 
> Unfortunately, I can't help you with reproducing, because I haven't
> necessary hardware.
> 
> Can you, please, try some older known to be good revision with
> the 422580c3cea7 patch applied?

Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
19d39a3810e if that helps. So that's with commit 422580c3cea7.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1688832

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Sun, Jul 16, 2017 at 10:59:42PM -0700, Tony Lindgren wrote:
> * Roman Gushchin <guro@fb.com> [170716 05:55]:
> > On Fri, Jul 14, 2017 at 07:23:43PM +0200, Sebastian Reichel wrote:
> > > On Fri, Jul 14, 2017 at 02:12:21PM +0000, Roman Gushchin wrote:
> > > > > On 14 Jul 2017, at 14:43, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote:
> > > > > I just bisected another issue breaking boot on Droid 4. My
> > > > > bisect points to 422580c3cea7 (mm/oom_kill.c: add tracepoints
> > > > > for oom reaper-related events). It do not see any message
> > > > > printed to UART (with earlyprintk) once that commit is part
> > > > > of my image. Kernel config is below.
> > > 
> > > > This is really interesting, because this patch adds few
> > > > tracepoints and all of them are called from the oom code, which is
> > > > hopefully not a part of the boot process.
> > > > 
> > > > Can you, please, confirm, that it can be reproduced with some
> > > > confidence? If so, can you, please, eliminate the tracepoints
> > > > calls and try to reproduce the boot failure?
> > > 
> > > I can boot 9967468c0a10 ("Merge branch 'akpm' (patches from
> > > Andrew)") after adding
> > > 
> > >  - http://git.kernel.org/tip/19d39a3810e7032f311ef83effdac40339b9d022
> > >    (another issue, that breaks Droid 4 boot)
> > >  - a git revert of 422580c3cea7
> > > 
> > > OTOH there are strange problems. Using da16dd9785f8 + above
> > > two commits also works. Using b5e16170f59b + above commits
> > > does not work and bisection ended up in the merge commit.
> > 
> > Hi, Sebastian!
> > 
> > As commit 422580c3cea7 hasn't added any code, which is executed
> > during the boot process, I could imagine only two options:
> > 1) Added code/data occasionally broke some alignment/size contraints.
> > 2) There is another instable bug, which compromised bisect results.
> > 
> > Unfortunately, I can't help you with reproducing, because I haven't
> > necessary hardware.
> > 
> > Can you, please, try some older known to be good revision with
> > the 422580c3cea7 patch applied?
> 
> Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
> 19d39a3810e if that helps. So that's with commit 422580c3cea7.

v4.13-rc1 + 19d39a3810e was also broken for me. I just disabled
some unused bits in my .config and now the kernel boots with
(with 422580c3cea7 that is). Maybe I hit some maximum image size
limit for Droid 4?

Anyways it looks like 422580c3cea7 is not the actual problem
and merely reveals some other problem.

-- Sebastian

[toc] | [prev] | [next] | [standalone]

#1688851

* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170717 02:52]:
> On Sun, Jul 16, 2017 at 10:59:42PM -0700, Tony Lindgren wrote:
> > Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
> > 19d39a3810e if that helps. So that's with commit 422580c3cea7.
> 
> v4.13-rc1 + 19d39a3810e was also broken for me. I just disabled
> some unused bits in my .config and now the kernel boots with
> (with 422580c3cea7 that is). Maybe I hit some maximum image size
> limit for Droid 4?
> 
> Anyways it looks like 422580c3cea7 is not the actual problem
> and merely reveals some other problem.

OK. Maybe check kexec --image-size configuration if you have
a huge static kernel?

Tony

[toc] | [prev] | [next] | [standalone]

#1688937

[Multipart message — attachments visible in raw view] — view raw

[dropping people from Cc]

Hi,

On Mon, Jul 17, 2017 at 03:19:28AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170717 02:52]:
> > On Sun, Jul 16, 2017 at 10:59:42PM -0700, Tony Lindgren wrote:
> > > Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
> > > 19d39a3810e if that helps. So that's with commit 422580c3cea7.
> > 
> > v4.13-rc1 + 19d39a3810e was also broken for me. I just disabled
> > some unused bits in my .config and now the kernel boots with
> > (with 422580c3cea7 that is). Maybe I hit some maximum image size
> > limit for Droid 4?
> > 
> > Anyways it looks like 422580c3cea7 is not the actual problem
> > and merely reveals some other problem.
> 
> OK. Maybe check kexec --image-size configuration if you have
> a huge static kernel?

I still use the IMGSIZE=26214400 from your kexec wrapper for
Droid 4, which should be 25MB. With the updated .config my
image looks like this:

$ ls -lh arch/arm/boot/*Image
-rwxr-xr-x 1 sre sre  17M Jul 17 12:44 arch/arm/boot/Image
-rwxr-xr-x 1 sre sre 7.2M Jul 17 12:44 arch/arm/boot/zImage

Unfortunately I did not check size before I dropped the config
options. I don't think I removed 8M of config options, but who
knows.

-- Sebastian

[toc] | [prev] | [next] | [standalone]

#1688956

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Mon, Jul 17, 2017 at 01:17:13PM +0200, Sebastian Reichel wrote:
> [dropping people from Cc]
> 
> Hi,
> 
> On Mon, Jul 17, 2017 at 03:19:28AM -0700, Tony Lindgren wrote:
> > * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170717 02:52]:
> > > On Sun, Jul 16, 2017 at 10:59:42PM -0700, Tony Lindgren wrote:
> > > > Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
> > > > 19d39a3810e if that helps. So that's with commit 422580c3cea7.
> > > 
> > > v4.13-rc1 + 19d39a3810e was also broken for me. I just disabled
> > > some unused bits in my .config and now the kernel boots with
> > > (with 422580c3cea7 that is). Maybe I hit some maximum image size
> > > limit for Droid 4?
> > > 
> > > Anyways it looks like 422580c3cea7 is not the actual problem
> > > and merely reveals some other problem.
> > 
> > OK. Maybe check kexec --image-size configuration if you have
> > a huge static kernel?
> 
> I still use the IMGSIZE=26214400 from your kexec wrapper for
> Droid 4, which should be 25MB. With the updated .config my
> image looks like this:
> 
> $ ls -lh arch/arm/boot/*Image
> -rwxr-xr-x 1 sre sre  17M Jul 17 12:44 arch/arm/boot/Image
> -rwxr-xr-x 1 sre sre 7.2M Jul 17 12:44 arch/arm/boot/zImage
> 
> Unfortunately I did not check size before I dropped the config
> options. I don't think I removed 8M of config options, but who
> knows.

I just enabled CONFIG_DEBUG_LOCKDEP=y and CONFIG_DEBUG_ATOMIC_SLEEP=y
and it did not boot again. Sizes are much smaller than kexec's
image-size parameter (26214400 - 25MB):

$ ls -l arch/arm/boot/Image
-rwxr-xr-x 1 sre sre 17768448 Jul 12 00:38 arch/arm/boot/Image

Then I increased image-size parameter to 33554432 (32MB) and it
boots again. So looks like it is a size problem. I wonder what
size this is about, though.

-- Sebastian

[toc] | [prev] | [next] | [standalone]

#1689753

* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170717 04:52]:
> Hi,
> 
> On Mon, Jul 17, 2017 at 01:17:13PM +0200, Sebastian Reichel wrote:
> > [dropping people from Cc]
> > 
> > Hi,
> > 
> > On Mon, Jul 17, 2017 at 03:19:28AM -0700, Tony Lindgren wrote:
> > > * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170717 02:52]:
> > > > On Sun, Jul 16, 2017 at 10:59:42PM -0700, Tony Lindgren wrote:
> > > > > Sebastian, for me droid 4 boots just fine with v4.13-rc1 +
> > > > > 19d39a3810e if that helps. So that's with commit 422580c3cea7.
> > > > 
> > > > v4.13-rc1 + 19d39a3810e was also broken for me. I just disabled
> > > > some unused bits in my .config and now the kernel boots with
> > > > (with 422580c3cea7 that is). Maybe I hit some maximum image size
> > > > limit for Droid 4?
> > > > 
> > > > Anyways it looks like 422580c3cea7 is not the actual problem
> > > > and merely reveals some other problem.
> > > 
> > > OK. Maybe check kexec --image-size configuration if you have
> > > a huge static kernel?
> > 
> > I still use the IMGSIZE=26214400 from your kexec wrapper for
> > Droid 4, which should be 25MB. With the updated .config my
> > image looks like this:
> > 
> > $ ls -lh arch/arm/boot/*Image
> > -rwxr-xr-x 1 sre sre  17M Jul 17 12:44 arch/arm/boot/Image
> > -rwxr-xr-x 1 sre sre 7.2M Jul 17 12:44 arch/arm/boot/zImage
> > 
> > Unfortunately I did not check size before I dropped the config
> > options. I don't think I removed 8M of config options, but who
> > knows.
> 
> I just enabled CONFIG_DEBUG_LOCKDEP=y and CONFIG_DEBUG_ATOMIC_SLEEP=y
> and it did not boot again. Sizes are much smaller than kexec's
> image-size parameter (26214400 - 25MB):
> 
> $ ls -l arch/arm/boot/Image
> -rwxr-xr-x 1 sre sre 17768448 Jul 12 00:38 arch/arm/boot/Image
> 
> Then I increased image-size parameter to 33554432 (32MB) and it
> boots again. So looks like it is a size problem. I wonder what
> size this is about, though.

Well recent kexec-tools attempts to calculate the size
automatically looking at kexec-tools commit 8d614008609f
("arm: use zImage size from header"). Maybe check what your
zImage header says for end - start?

Regards,

Tony

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web