Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687916 > unrolled thread

Re: [PATCH 1/9] rbtree: Cache leftmost node internally

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/9] rbtree: Cache leftmost node internally Christoph Hellwig <hch@infradead.org> - 2017-07-15 13:00 +0200
    Re: [PATCH 1/9] rbtree: Cache leftmost node internally Davidlohr Bueso <dave@stgolabs.net> - 2017-07-15 17:30 +0200

#1687916 — Re: [PATCH 1/9] rbtree: Cache leftmost node internally

Is the leftmost node so much more special than the rightmost one?

Just asking because I have some code that caches both of them, but
using your helpers would make it look very asymmetric..

[toc] | [next] | [standalone]

#1687960

On Sat, 15 Jul 2017, Christoph Hellwig wrote:

>Is the leftmost node so much more special than the rightmost one?
>
>Just asking because I have some code that caches both of them, but
>using your helpers would make it look very asymmetric..

Yeah, I thought of this, but ultimately decided that the leftmost
node was more used (rb_first vs rb_last calls) and probably not
worth adding the rightmost one which would endup enlarging the
structure even more.

That said, I do have some patches for the rbtree users to cache the
rightmost node, similarly to how it was done with the leftmost
before this patchset.

If folks don't mind enlarging rb_root_cached, I could definitely
add the rightmost, but it seems an overkill -- albeit asymmetric.

Thanks,
Davidlohr

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web