Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687850 > unrolled thread

[PATCH 00/10] Constify isdn pci_device_id's.

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-07-15 06:30 +0200
Last post2017-07-16 06:30 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/10] Constify isdn pci_device_id's. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-15 06:30 +0200
    [PATCH 04/10] isdn: eicon: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-15 06:30 +0200
    [PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-15 06:30 +0200
    [PATCH 10/10] isdn: avm: c4: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-15 06:30 +0200
    [PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-15 06:30 +0200
    Re: [PATCH 00/10] Constify isdn pci_device_id's. David Miller <davem@davemloft.net> - 2017-07-16 06:30 +0200

#1687850 — [PATCH 00/10] Constify isdn pci_device_id's.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-15 06:30 +0200
Subject[PATCH 00/10] Constify isdn pci_device_id's.
Message-ID<u3mSl-5dk-3@gated-at.bofh.it>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (10):
  [PATCH 01/10] isdn: hisax: constify pci_device_id.
  [PATCH 02/10] isdn: hisax: hfc4s8s_l1: constify pci_device_id.
  [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: constify pci_device_id.
  [PATCH 04/10] isdn: eicon: constify pci_device_id.
  [PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id.
  [PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id.
  [PATCH 07/10] isdn: mISDN: w6692: constify pci_device_id.
  [PATCH 08/10] isdn: mISDN: avmfritz: constify pci_device_id.
  [PATCH 09/10] isdn: mISDN: hfcpci: constify pci_device_id.
  [PATCH 10/10] isdn: avm: c4: constify pci_device_id.

 drivers/isdn/hardware/avm/c4.c          | 2 +-
 drivers/isdn/hardware/eicon/divasmain.c | 2 +-
 drivers/isdn/hardware/mISDN/avmfritz.c  | 2 +-
 drivers/isdn/hardware/mISDN/hfcmulti.c  | 2 +-
 drivers/isdn/hardware/mISDN/hfcpci.c    | 2 +-
 drivers/isdn/hardware/mISDN/netjet.c    | 2 +-
 drivers/isdn/hardware/mISDN/w6692.c     | 2 +-
 drivers/isdn/hisax/config.c             | 2 +-
 drivers/isdn/hisax/hfc4s8s_l1.c         | 2 +-
 drivers/isdn/hisax/hisax_fcpcipnp.c     | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1687851 — [PATCH 04/10] isdn: eicon: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-15 06:30 +0200
Subject[PATCH 04/10] isdn: eicon: constify pci_device_id.
Message-ID<u3mSm-5dk-17@gated-at.bofh.it>
In reply to#1687850
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   6224	    655	      8	   6887	   1ae7	isdn/hardware/eicon/divasmain.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   6608	    271	      8	   6887	   1ae7	isdn/hardware/eicon/divasmain.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hardware/eicon/divasmain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/eicon/divasmain.c b/drivers/isdn/hardware/eicon/divasmain.c
index 8b7ad4f..b2023e0 100644
--- a/drivers/isdn/hardware/eicon/divasmain.c
+++ b/drivers/isdn/hardware/eicon/divasmain.c
@@ -110,7 +110,7 @@ typedef struct _diva_os_thread_dpc {
 /*
   This table should be sorted by PCI device ID
 */
-static struct pci_device_id divas_pci_tbl[] = {
+static const struct pci_device_id divas_pci_tbl[] = {
 	/* Diva Server BRI-2M PCI 0xE010 */
 	{ PCI_VDEVICE(EICON, PCI_DEVICE_ID_EICON_MAESTRA),
 	  CARDTYPE_MAESTRA_PCI },
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1687852 — [PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-15 06:30 +0200
Subject[PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id.
Message-ID<u3mSm-5dk-21@gated-at.bofh.it>
In reply to#1687850
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  10941	   1776	     16	  12733	   31bd isdn/hardware/mISDN/netjet.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  11005	   1712	     16	  12733	   31bd isdn/hardware/mISDN/netjet.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hardware/mISDN/netjet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c
index afde4ed..6a6d848 100644
--- a/drivers/isdn/hardware/mISDN/netjet.c
+++ b/drivers/isdn/hardware/mISDN/netjet.c
@@ -1137,7 +1137,7 @@ static void nj_remove(struct pci_dev *pdev)
 /* We cannot select cards with PCI_SUB... IDs, since here are cards with
  * SUB IDs set to PCI_ANY_ID, so we need to match all and reject
  * known other cards which not work with this driver - see probe function */
-static struct pci_device_id nj_pci_ids[] = {
+static const struct pci_device_id nj_pci_ids[] = {
 	{ PCI_VENDOR_ID_TIGERJET, PCI_DEVICE_ID_TIGERJET_300,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 	{ }
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1687853 — [PATCH 10/10] isdn: avm: c4: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-15 06:30 +0200
Subject[PATCH 10/10] isdn: avm: c4: constify pci_device_id.
Message-ID<u3mSm-5dk-19@gated-at.bofh.it>
In reply to#1687850
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  11803	    544	      1	  12348	   303c	isdn/hardware/avm/c4.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  11931	    416	      1	  12348	   303c	isdn/hardware/avm/c4.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hardware/avm/c4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/avm/c4.c b/drivers/isdn/hardware/avm/c4.c
index 40c7e2c..034caba 100644
--- a/drivers/isdn/hardware/avm/c4.c
+++ b/drivers/isdn/hardware/avm/c4.c
@@ -42,7 +42,7 @@ static char *revision = "$Revision: 1.1.2.2 $";
 
 static bool suppress_pollack;
 
-static struct pci_device_id c4_pci_tbl[] = {
+static const struct pci_device_id c4_pci_tbl[] = {
 	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C4, 0, 0, (unsigned long)4 },
 	{ PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_C2, 0, 0, (unsigned long)2 },
 	{ }			/* Terminating entry */
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1687855 — [PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-15 06:30 +0200
Subject[PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id.
Message-ID<u3mSm-5dk-23@gated-at.bofh.it>
In reply to#1687850
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  63450	   1536	   1492	  66478	  103ae	isdn/hardware/mISDN/hfcmulti.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  64698	    288	   1492	  66478	  103ae	isdn/hardware/mISDN/hfcmulti.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index aea0c96..3cf07b8 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5348,7 +5348,7 @@ static const struct hm_map hfcm_map[] = {
 
 #undef H
 #define H(x)	((unsigned long)&hfcm_map[x])
-static struct pci_device_id hfmultipci_ids[] = {
+static const struct pci_device_id hfmultipci_ids[] = {
 
 	/* Cards with HFC-4S Chip */
 	{ PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1688114

FromDavid Miller <davem@davemloft.net>
Date2017-07-16 06:30 +0200
Message-ID<u3JlT-2lT-3@gated-at.bofh.it>
In reply to#1687850
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Sat, 15 Jul 2017 09:55:41 +0530

> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.

Series applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web