Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686863 > unrolled thread

[PATCH 0/2] Fix modify_qp failure

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Fix modify_qp failure Mustafa Ismail <mustafa.ismail@intel.com> - 2017-07-13 21:40 +0200
    [PATCH 1/2] RDMA/uverbs: Fix the check for port number Mustafa Ismail <mustafa.ismail@intel.com> - 2017-07-13 21:40 +0200
      RE: [PATCH 1/2] RDMA/uverbs: Fix the check for port number "Steve Wise" <swise@opengridcomputing.com> - 2017-07-13 22:30 +0200
      Re: [PATCH 1/2] RDMA/uverbs: Fix the check for port number Greg KH <gregkh@linuxfoundation.org> - 2017-07-14 08:50 +0200

#1686863 — [PATCH 0/2] Fix modify_qp failure

Commit 5ecce4c9b17b("Check port number supplied by user verbs cmds") causes
modify_qp to fail because port_num is only valid when the mask is set.

Additionally, for iWARP, the port_num is not initialized which also causes
modify_qp to fail.

This series fixes both issues.

Mustafa Ismail (2):
  RDMA/uverbs: Fix the check for port number
  RDMA/core: Initialize port_num in qp_attr

 drivers/infiniband/core/cma.c        | 2 ++
 drivers/infiniband/core/uverbs_cmd.c | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1686864 — [PATCH 1/2] RDMA/uverbs: Fix the check for port number

The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.

Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
---
 drivers/infiniband/core/uverbs_cmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 8ba9bfb..19de068 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1935,7 +1935,8 @@ static int modify_qp(struct ib_uverbs_file *file,
 		goto out;
 	}
 
-	if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
+	if ((cmd->base.attr_mask & IB_QP_PORT) &&
+	    !rdma_is_port_valid(qp->device, cmd->base.port_num)) {
 		ret = -EINVAL;
 		goto release_qp;
 	}
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1686885 — RE: [PATCH 1/2] RDMA/uverbs: Fix the check for port number

> The port number is only valid if IB_QP_PORT is set in the mask.
> So only check port number if it is valid to prevent modify_qp from
> failing due to an invalid port number.
> 
> Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>

Looks good.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

[toc] | [prev] | [next] | [standalone]

#1687107 — Re: [PATCH 1/2] RDMA/uverbs: Fix the check for port number

On Thu, Jul 13, 2017 at 02:37:37PM -0500, Mustafa Ismail wrote:
> The port number is only valid if IB_QP_PORT is set in the mask.
> So only check port number if it is valid to prevent modify_qp from
> failing due to an invalid port number.
> 
> Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> ---
>  drivers/infiniband/core/uverbs_cmd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web