Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1685796 > unrolled thread
| Started by | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| First post | 2017-07-12 16:10 +0200 |
| Last post | 2017-07-14 12:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-12 16:10 +0200
Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present Sudeep Holla <sudeep.holla@arm.com> - 2017-07-12 18:40 +0200
Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present Sudeep Holla <sudeep.holla@arm.com> - 2017-07-14 12:40 +0200
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-07-12 16:10 +0200 |
| Subject | Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present |
| Message-ID | <u2quZ-LL-9@gated-at.bofh.it> |
On 29 June 2017 at 20:00, Sudeep Holla <sudeep.holla@arm.com> wrote: > If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach > may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets > the PM domain for the device unconditionally. > > When subsequent attempts are made to call genpd_dev_pm_attach, it may > return -EEXISTS checking dev->pm_domain without re-attempting to call > attach_dev or power_on. > > platform_drv_probe then attempts to call drv->probe as the return value > -EEXIST != -EPROBE_DEFER, which may end up in a situation where the > device is accessed without it's power domain switched on. Right, this makes sense. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Kevin Hilman <khilman@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Could we perhaps work out which commit it fixes, or perhaps the problem been there long time ago and we should just add a stable tag? > --- > drivers/base/power/domain.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index da49a8383dc3..b195d34de888 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1168,8 +1168,6 @@ static struct generic_pm_domain_data *genpd_alloc_dev_data(struct device *dev, > > spin_unlock_irq(&dev->power.lock); > > - dev_pm_domain_set(dev, &genpd->domain); > - > return gpd_data; > > err_free: > @@ -1221,6 +1219,8 @@ static int genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, > if (ret) > goto out; > > + dev_pm_domain_set(dev, &genpd->domain); > + > genpd->device_count++; > genpd->max_off_time_changed = true; > > -- > 2.7.4 > One piece is missing to make this fix complete. More precisely, you must also move the call to dev_pm_domain_set(dev, NULL). Currently that is done from genpd_free_dev_data(), as it corresponds to genpd_alloc_dev_data(), but clearly the proper place to call it should be from genpd_remove_device(). Kind regards Uffe
[toc] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-07-12 18:40 +0200 |
| Message-ID | <u2sQ9-28X-7@gated-at.bofh.it> |
| In reply to | #1685796 |
On 12/07/17 14:59, Ulf Hansson wrote: > On 29 June 2017 at 20:00, Sudeep Holla <sudeep.holla@arm.com> wrote: >> If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach >> may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets >> the PM domain for the device unconditionally. >> >> When subsequent attempts are made to call genpd_dev_pm_attach, it may >> return -EEXISTS checking dev->pm_domain without re-attempting to call >> attach_dev or power_on. >> >> platform_drv_probe then attempts to call drv->probe as the return value >> -EEXIST != -EPROBE_DEFER, which may end up in a situation where the >> device is accessed without it's power domain switched on. > > Right, this makes sense. > Thanks >> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Kevin Hilman <khilman@kernel.org> >> Cc: Ulf Hansson <ulf.hansson@linaro.org> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > Could we perhaps work out which commit it fixes, or perhaps the > problem been there long time ago and we should just add a stable tag? > OK I will dig that out. >> --- >> drivers/base/power/domain.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c >> index da49a8383dc3..b195d34de888 100644 >> --- a/drivers/base/power/domain.c >> +++ b/drivers/base/power/domain.c >> @@ -1168,8 +1168,6 @@ static struct generic_pm_domain_data *genpd_alloc_dev_data(struct device *dev, >> >> spin_unlock_irq(&dev->power.lock); >> >> - dev_pm_domain_set(dev, &genpd->domain); >> - >> return gpd_data; >> >> err_free: >> @@ -1221,6 +1219,8 @@ static int genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, >> if (ret) >> goto out; >> >> + dev_pm_domain_set(dev, &genpd->domain); >> + >> genpd->device_count++; >> genpd->max_off_time_changed = true; >> >> -- >> 2.7.4 >> > > One piece is missing to make this fix complete. > > More precisely, you must also move the call to dev_pm_domain_set(dev, NULL). > Sure will add. > Currently that is done from genpd_free_dev_data(), as it corresponds > to genpd_alloc_dev_data(), but clearly the proper place to call it > should be from genpd_remove_device(). > OK, will also look into that. -- Regards, Sudeep
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-07-14 12:40 +0200 |
| Message-ID | <u36aS-28v-9@gated-at.bofh.it> |
| In reply to | #1685895 |
On 12/07/17 17:36, Sudeep Holla wrote:
>
>
> On 12/07/17 14:59, Ulf Hansson wrote:
>> On 29 June 2017 at 20:00, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>> If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach
>>> may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets
>>> the PM domain for the device unconditionally.
>>>
>>> When subsequent attempts are made to call genpd_dev_pm_attach, it may
>>> return -EEXISTS checking dev->pm_domain without re-attempting to call
>>> attach_dev or power_on.
>>>
>>> platform_drv_probe then attempts to call drv->probe as the return value
>>> -EEXIST != -EPROBE_DEFER, which may end up in a situation where the
>>> device is accessed without it's power domain switched on.
>>
>> Right, this makes sense.
>>
>
> Thanks
>
>>>
>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>>> Cc: Kevin Hilman <khilman@kernel.org>
>>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>
>> Could we perhaps work out which commit it fixes, or perhaps the
>> problem been there long time ago and we should just add a stable tag?
>>
>
> OK I will dig that out.
>
It looks like commit 989561de9b51 ("PM / Domains: add setter for
dev.pm_domain") added the helper. I then follow it to commit
f104e1e5ef57 ("PM / Domains: Re-order initialization of
generic_pm_domain_data"). The code in the original commit 6ff7bb0d02f8
("PM / Domains: Cache device stop and domain power off governor results,
v3") looks OK to me.
So What should I do ? Add
Fixes: f104e1e5ef57 ("PM / Domains: Re-order initialization of
generic_pm_domain_data")
tag in the mainline. And when Greg or others fix up before v4.4, I need
to work out the fix for that stable version ?
--
Regards,
Sudeep
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web