Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684697 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| First post | 2017-07-11 01:50 +0200 |
| Last post | 2017-07-12 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v6 1/4] firmware: scm: Add new SCM call API for switching memory ownership Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-11 01:50 +0200
Re: [PATCH v6 1/4] firmware: scm: Add new SCM call API for switching memory ownership "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> - 2017-07-12 13:10 +0200
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2017-07-11 01:50 +0200 |
| Subject | Re: [PATCH v6 1/4] firmware: scm: Add new SCM call API for switching memory ownership |
| Message-ID | <u1QBc-38v-9@gated-at.bofh.it> |
On Thu 22 Jun 05:08 PDT 2017, Avaneesh Kumar Dwivedi wrote:
> Two different processors on a SOC need to switch memory ownership
> during load/unload. To enable this, second level memory map table
> need to be updated, which is done by secure layer.
> This patch adds the interface for making secure monitor call for
> memory ownership switching request.
>
> Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
> ---
> drivers/firmware/qcom_scm-32.c | 6 +++
> drivers/firmware/qcom_scm-64.c | 27 +++++++++++++
> drivers/firmware/qcom_scm.c | 92 ++++++++++++++++++++++++++++++++++++++++++
> drivers/firmware/qcom_scm.h | 5 +++
> include/linux/qcom_scm.h | 16 ++++++++
> 5 files changed, 146 insertions(+)
>
> diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
> index 93e3b96..a5e038d 100644
> --- a/drivers/firmware/qcom_scm-32.c
> +++ b/drivers/firmware/qcom_scm-32.c
> @@ -596,3 +596,9 @@ int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size,
> {
> return -ENODEV;
> }
> +int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region,
> + size_t mem_sz, phys_addr_t src, size_t src_sz,
> + phys_addr_t dest, size_t dest_sz)
> +{
> + return -ENODEV;
> +}
> diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c
> index 6e6d561..cdfe986 100644
> --- a/drivers/firmware/qcom_scm-64.c
> +++ b/drivers/firmware/qcom_scm-64.c
> @@ -439,3 +439,30 @@ int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size,
>
> return ret;
> }
> +
> +int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region,
> + size_t mem_sz, phys_addr_t src, size_t src_sz,
> + phys_addr_t dest, size_t dest_sz)
> +{
> + int ret;
> + struct qcom_scm_desc desc = {0};
> + struct arm_smccc_res res;
> +
> + desc.args[0] = mem_region;
> + desc.args[1] = mem_sz;
> + desc.args[2] = src;
> + desc.args[3] = src_sz;
> + desc.args[4] = dest;
> + desc.args[5] = dest_sz;
> + desc.args[6] = 0;
> +
> + desc.arginfo = QCOM_SCM_ARGS(7, QCOM_SCM_RO, QCOM_SCM_VAL,
> + QCOM_SCM_RO, QCOM_SCM_VAL, QCOM_SCM_RO,
> + QCOM_SCM_VAL, QCOM_SCM_VAL);
> +
> + ret = qcom_scm_call(dev, QCOM_SCM_SVC_MP,
> + QCOM_MEM_PROT_ASSIGN_ID,
> + &desc, &res);
Please indent broken lines by the start parenthesis, throughout the
patch, this makes the code easier to read. You can run checkpatch.pl
with the --strict flag to show a few other places below that has the
same issue.
Please clean these up together with the dma allocation and the return
value as pointed out by Stephen and I'm happy to pick the series up.
Regards,
Bjorn
[toc] | [next] | [standalone]
| From | "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> |
|---|---|
| Date | 2017-07-12 13:10 +0200 |
| Message-ID | <u2nGP-7sP-37@gated-at.bofh.it> |
| In reply to | #1684697 |
On 7/11/2017 5:13 AM, Bjorn Andersson wrote:
> On Thu 22 Jun 05:08 PDT 2017, Avaneesh Kumar Dwivedi wrote:
>
>> Two different processors on a SOC need to switch memory ownership
>> during load/unload. To enable this, second level memory map table
>> need to be updated, which is done by secure layer.
>> This patch adds the interface for making secure monitor call for
>> memory ownership switching request.
>>
>> Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
>> ---
>> drivers/firmware/qcom_scm-32.c | 6 +++
>> drivers/firmware/qcom_scm-64.c | 27 +++++++++++++
>> drivers/firmware/qcom_scm.c | 92 ++++++++++++++++++++++++++++++++++++++++++
>> drivers/firmware/qcom_scm.h | 5 +++
>> include/linux/qcom_scm.h | 16 ++++++++
>> 5 files changed, 146 insertions(+)
>>
>> diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
>> index 93e3b96..a5e038d 100644
>> --- a/drivers/firmware/qcom_scm-32.c
>> +++ b/drivers/firmware/qcom_scm-32.c
>> @@ -596,3 +596,9 @@ int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size,
>> {
>> return -ENODEV;
>> }
>> +int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region,
>> + size_t mem_sz, phys_addr_t src, size_t src_sz,
>> + phys_addr_t dest, size_t dest_sz)
>> +{
>> + return -ENODEV;
>> +}
>> diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c
>> index 6e6d561..cdfe986 100644
>> --- a/drivers/firmware/qcom_scm-64.c
>> +++ b/drivers/firmware/qcom_scm-64.c
>> @@ -439,3 +439,30 @@ int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size,
>>
>> return ret;
>> }
>> +
>> +int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region,
>> + size_t mem_sz, phys_addr_t src, size_t src_sz,
>> + phys_addr_t dest, size_t dest_sz)
>> +{
>> + int ret;
>> + struct qcom_scm_desc desc = {0};
>> + struct arm_smccc_res res;
>> +
>> + desc.args[0] = mem_region;
>> + desc.args[1] = mem_sz;
>> + desc.args[2] = src;
>> + desc.args[3] = src_sz;
>> + desc.args[4] = dest;
>> + desc.args[5] = dest_sz;
>> + desc.args[6] = 0;
>> +
>> + desc.arginfo = QCOM_SCM_ARGS(7, QCOM_SCM_RO, QCOM_SCM_VAL,
>> + QCOM_SCM_RO, QCOM_SCM_VAL, QCOM_SCM_RO,
>> + QCOM_SCM_VAL, QCOM_SCM_VAL);
>> +
>> + ret = qcom_scm_call(dev, QCOM_SCM_SVC_MP,
>> + QCOM_MEM_PROT_ASSIGN_ID,
>> + &desc, &res);
> Please indent broken lines by the start parenthesis, throughout the
> patch, this makes the code easier to read. You can run checkpatch.pl
> with the --strict flag to show a few other places below that has the
> same issue.
>
>
> Please clean these up together with the dma allocation and the return
> value as pointed out by Stephen and I'm happy to pick the series up.
Sure, thank you, will do and send out by eod tomorrow.
>
> Regards,
> Bjorn
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web