Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1685611 > unrolled thread
| Started by | Benjamin Gaignard <benjamin.gaignard@linaro.org> |
|---|---|
| First post | 2017-07-12 10:20 +0200 |
| Last post | 2017-07-12 22:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-07-12 10:20 +0200
Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions Michael Chan <michael.chan@broadcom.com> - 2017-07-12 22:10 +0200
| From | Benjamin Gaignard <benjamin.gaignard@linaro.org> |
|---|---|
| Date | 2017-07-12 10:20 +0200 |
| Subject | [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions |
| Message-ID | <u2l2h-5IN-7@gated-at.bofh.it> |
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> CC: Michael Chan <michael.chan@broadcom.com> CC: netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index b56c54d..9fef202 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -4703,7 +4703,7 @@ int bnxt_hwrm_fw_set_time(struct bnxt *bp) return -EOPNOTSUPP; do_gettimeofday(&tv); - rtc_time_to_tm(tv.tv_sec, &tm); + rtc_time64_to_tm(tv.tv_sec, &tm); bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_FW_SET_TIME, -1, -1); req.year = cpu_to_le16(1900 + tm.tm_year); req.month = 1 + tm.tm_mon; -- 1.9.1
[toc] | [next] | [standalone]
| From | Michael Chan <michael.chan@broadcom.com> |
|---|---|
| Date | 2017-07-12 22:10 +0200 |
| Message-ID | <u2w7o-4oh-11@gated-at.bofh.it> |
| In reply to | #1685611 |
On Wed, Jul 12, 2017 at 1:04 AM, Benjamin Gaignard <benjamin.gaignard@linaro.org> wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. > Stop using those two functions to safer 64bits ones. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > CC: Michael Chan <michael.chan@broadcom.com> > CC: netdev@vger.kernel.org > CC: linux-kernel@vger.kernel.org Acked-by: Michael Chan <michael.chan@broadcom.com> Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web