Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683998 > unrolled thread
| Started by | Yijing Wang <wangyijing@huawei.com> |
|---|---|
| First post | 2017-07-10 09:10 +0200 |
| Last post | 2017-07-14 08:50 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 2/7] libsas: remove unused port_gone_completion Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion John Garry <john.garry@huawei.com> - 2017-07-11 18:00 +0200
Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion wangyijing <wangyijing@huawei.com> - 2017-07-12 04:20 +0200
Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion Hannes Reinecke <hare@suse.de> - 2017-07-14 08:50 +0200
| From | Yijing Wang <wangyijing@huawei.com> |
|---|---|
| Date | 2017-07-10 09:10 +0200 |
| Subject | [PATCH v3 2/7] libsas: remove unused port_gone_completion |
| Message-ID | <u1AZr-1Sl-5@gated-at.bofh.it> |
No one uses the port_gone_completion in struct asd_sas_port,
clean it out.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
include/scsi/libsas.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index c41328d..628f48b 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -263,8 +263,6 @@ struct sas_discovery {
/* The port struct is Class:RW, driver:RO */
struct asd_sas_port {
/* private: */
- struct completion port_gone_completion;
-
struct sas_discovery disc;
struct domain_device *port_dev;
spinlock_t dev_list_lock;
--
2.5.0
[toc] | [next] | [standalone]
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Date | 2017-07-11 18:00 +0200 |
| Message-ID | <u25JU-4bX-11@gated-at.bofh.it> |
| In reply to | #1683998 |
On 10/07/2017 08:06, Yijing Wang wrote:
> No one uses the port_gone_completion in struct asd_sas_port,
> clean it out.
This seems like a reasonable tidy-up patch which could be taken in
isolation, having no dependency on the rest of the series.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> include/scsi/libsas.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index c41328d..628f48b 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -263,8 +263,6 @@ struct sas_discovery {
> /* The port struct is Class:RW, driver:RO */
> struct asd_sas_port {
> /* private: */
> - struct completion port_gone_completion;
> -
> struct sas_discovery disc;
> struct domain_device *port_dev;
> spinlock_t dev_list_lock;
>
[toc] | [prev] | [next] | [standalone]
| From | wangyijing <wangyijing@huawei.com> |
|---|---|
| Date | 2017-07-12 04:20 +0200 |
| Message-ID | <u2fpU-22S-1@gated-at.bofh.it> |
| In reply to | #1685169 |
在 2017/7/11 23:54, John Garry 写道:
> On 10/07/2017 08:06, Yijing Wang wrote:
>> No one uses the port_gone_completion in struct asd_sas_port,
>> clean it out.
>
> This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series.
Yes.
>
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> include/scsi/libsas.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
>> index c41328d..628f48b 100644
>> --- a/include/scsi/libsas.h
>> +++ b/include/scsi/libsas.h
>> @@ -263,8 +263,6 @@ struct sas_discovery {
>> /* The port struct is Class:RW, driver:RO */
>> struct asd_sas_port {
>> /* private: */
>> - struct completion port_gone_completion;
>> -
>> struct sas_discovery disc;
>> struct domain_device *port_dev;
>> spinlock_t dev_list_lock;
>>
>
>
>
> .
>
[toc] | [prev] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2017-07-14 08:50 +0200 |
| Message-ID | <u32Ai-84Q-11@gated-at.bofh.it> |
| In reply to | #1683998 |
On 07/10/2017 09:06 AM, Yijing Wang wrote:
> No one uses the port_gone_completion in struct asd_sas_port,
> clean it out.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> include/scsi/libsas.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index c41328d..628f48b 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -263,8 +263,6 @@ struct sas_discovery {
> /* The port struct is Class:RW, driver:RO */
> struct asd_sas_port {
> /* private: */
> - struct completion port_gone_completion;
> -
> struct sas_discovery disc;
> struct domain_device *port_dev;
> spinlock_t dev_list_lock;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web