Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683995 > unrolled thread
| Started by | Jonathan Liu <net147@gmail.com> |
|---|---|
| First post | 2017-07-10 09:00 +0200 |
| Last post | 2017-07-17 08:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Jonathan Liu <net147@gmail.com> - 2017-07-10 09:00 +0200
Re: [linux-sunxi] [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Olliver Schinagl <oliver+list@schinagl.nl> - 2017-07-10 16:30 +0200
Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-11 21:30 +0200
Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Chen-Yu Tsai <wens@csie.org> - 2017-07-12 04:50 +0200
Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-17 08:30 +0200
| From | Jonathan Liu <net147@gmail.com> |
|---|---|
| Date | 2017-07-10 09:00 +0200 |
| Subject | [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console |
| Message-ID | <u1APM-1zU-11@gated-at.bofh.it> |
The drm_driver lastclose callback is called when the last userspace
DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
the fbdev console otherwise the fbdev console will stop working.
Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
Cc: stable@vger.kernel.org
Signed-off-by: Jonathan Liu <net147@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
---
Changes for v3:
- Add 'Fixes:' tag
- Add CC to stable
- Add 'Reviewed-by: Chen-Yu Tsai <wens@csie.org>'
Changes for v2:
- Rename sun4i_drm_lastclose to sun4i_drv_lastclose
drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index abc7d8fe06b4..a45a627283a1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -25,12 +25,20 @@
#include "sun4i_framebuffer.h"
#include "sun4i_tcon.h"
+static void sun4i_drv_lastclose(struct drm_device *dev)
+{
+ struct sun4i_drv *drv = dev->dev_private;
+
+ drm_fbdev_cma_restore_mode(drv->fbdev);
+}
+
DEFINE_DRM_GEM_CMA_FOPS(sun4i_drv_fops);
static struct drm_driver sun4i_drv_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_ATOMIC,
/* Generic Operations */
+ .lastclose = sun4i_drv_lastclose,
.fops = &sun4i_drv_fops,
.name = "sun4i-drm",
.desc = "Allwinner sun4i Display Engine",
--
2.13.2
[toc] | [next] | [standalone]
| From | Olliver Schinagl <oliver+list@schinagl.nl> |
|---|---|
| Date | 2017-07-10 16:30 +0200 |
| Subject | Re: [linux-sunxi] [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console |
| Message-ID | <u1HRg-67w-13@gated-at.bofh.it> |
| In reply to | #1683995 |
Hey Jonathan,
since I reported this to you on IRC, it's only fair that you can have my:
Tested-by: Olliver Schinagl <oliver@schinagl.nl>
For those interessted, I've tested it on an Olimex OLinuXino Lime2 with
their 4.3 LCD.
Olliver
On 10-07-17 08:55, Jonathan Liu wrote:
> The drm_driver lastclose callback is called when the last userspace
> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> the fbdev console otherwise the fbdev console will stop working.
>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Changes for v3:
> - Add 'Fixes:' tag
> - Add CC to stable
> - Add 'Reviewed-by: Chen-Yu Tsai <wens@csie.org>'
>
> Changes for v2:
> - Rename sun4i_drm_lastclose to sun4i_drv_lastclose
>
> drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> index abc7d8fe06b4..a45a627283a1 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> @@ -25,12 +25,20 @@
> #include "sun4i_framebuffer.h"
> #include "sun4i_tcon.h"
>
> +static void sun4i_drv_lastclose(struct drm_device *dev)
> +{
> + struct sun4i_drv *drv = dev->dev_private;
> +
> + drm_fbdev_cma_restore_mode(drv->fbdev);
> +}
> +
> DEFINE_DRM_GEM_CMA_FOPS(sun4i_drv_fops);
>
> static struct drm_driver sun4i_drv_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_ATOMIC,
>
> /* Generic Operations */
> + .lastclose = sun4i_drv_lastclose,
> .fops = &sun4i_drv_fops,
> .name = "sun4i-drm",
> .desc = "Allwinner sun4i Display Engine",
>
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-07-11 21:30 +0200 |
| Subject | Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console |
| Message-ID | <u2918-6o3-19@gated-at.bofh.it> |
| In reply to | #1683995 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Jul 10, 2017 at 04:55:04PM +1000, Jonathan Liu wrote:
> The drm_driver lastclose callback is called when the last userspace
> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> the fbdev console otherwise the fbdev console will stop working.
>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Queued for 4.14, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-07-12 04:50 +0200 |
| Subject | Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console |
| Message-ID | <u2fSW-2cb-5@gated-at.bofh.it> |
| In reply to | #1685307 |
On Wed, Jul 12, 2017 at 3:21 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Mon, Jul 10, 2017 at 04:55:04PM +1000, Jonathan Liu wrote:
>> The drm_driver lastclose callback is called when the last userspace
>> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
>> the fbdev console otherwise the fbdev console will stop working.
>>
>> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> Queued for 4.14, thanks!
May we have this sooner? Like 4.13? :)
ChenYu
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-07-17 08:30 +0200 |
| Subject | Re: [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console |
| Message-ID | <u47HA-1mx-5@gated-at.bofh.it> |
| In reply to | #1685472 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Jul 12, 2017 at 10:40:16AM +0800, Chen-Yu Tsai wrote:
> On Wed, Jul 12, 2017 at 3:21 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Mon, Jul 10, 2017 at 04:55:04PM +1000, Jonathan Liu wrote:
> >> The drm_driver lastclose callback is called when the last userspace
> >> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> >> the fbdev console otherwise the fbdev console will stop working.
> >>
> >> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Queued for 4.14, thanks!
>
> May we have this sooner? Like 4.13? :)
Yes, of course :)
I queued it for 4.13.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web