Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684365 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2017-07-10 17:50 +0200 |
| Last post | 2017-07-17 08:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability Chen-Yu Tsai <wens@csie.org> - 2017-07-10 17:50 +0200
Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-11 21:40 +0200
Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability Chen-Yu Tsai <wens@csie.org> - 2017-07-12 04:40 +0200
Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-17 08:30 +0200
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-07-10 17:50 +0200 |
| Subject | Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability |
| Message-ID | <u1J6F-6RW-9@gated-at.bofh.it> |
On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@kernel.org> wrote: > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote: >> The explanation for the endpoint ID numbering scheme is convoluted >> and hard to understand. >> >> This patch aims to improve the readability of it by combining the >> existing two paragraphs, while also providing a diagram example, >> and how endpoints should be numbered based on that example. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> >> Hope this helps. I'm not sure I can improve this even more without >> spelling out all cases. >> >> --- >> .../bindings/display/sunxi/sun4i-drm.txt | 36 ++++++++++++++++------ >> 1 file changed, 27 insertions(+), 9 deletions(-) > > Acked-by: Rob Herring <robh@kernel.org> Maxime, this patch seems to have fallen through the cracks. Could you queue it as a fix for 4.13? Thanks ChenYu
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-07-11 21:40 +0200 |
| Subject | Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability |
| Message-ID | <u29aN-6ru-17@gated-at.bofh.it> |
| In reply to | #1684365 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Jul 10, 2017 at 11:48:00PM +0800, Chen-Yu Tsai wrote: > On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@kernel.org> wrote: > > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote: > >> The explanation for the endpoint ID numbering scheme is convoluted > >> and hard to understand. > >> > >> This patch aims to improve the readability of it by combining the > >> existing two paragraphs, while also providing a diagram example, > >> and how endpoints should be numbered based on that example. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> > >> Hope this helps. I'm not sure I can improve this even more without > >> spelling out all cases. > >> > >> --- > >> .../bindings/display/sunxi/sun4i-drm.txt | 36 ++++++++++++++++------ > >> 1 file changed, 27 insertions(+), 9 deletions(-) > > > > Acked-by: Rob Herring <robh@kernel.org> > > Maxime, this patch seems to have fallen through the cracks. > > Could you queue it as a fix for 4.13? Sorry, I don't know why I overlooked it. Is it really 4.13 material though? It doesn't look that urgent. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-07-12 04:40 +0200 |
| Message-ID | <u2fJf-290-1@gated-at.bofh.it> |
| In reply to | #1685313 |
On Wed, Jul 12, 2017 at 3:31 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jul 10, 2017 at 11:48:00PM +0800, Chen-Yu Tsai wrote: >> On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@kernel.org> wrote: >> > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote: >> >> The explanation for the endpoint ID numbering scheme is convoluted >> >> and hard to understand. >> >> >> >> This patch aims to improve the readability of it by combining the >> >> existing two paragraphs, while also providing a diagram example, >> >> and how endpoints should be numbered based on that example. >> >> >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> >> --- >> >> >> >> Hope this helps. I'm not sure I can improve this even more without >> >> spelling out all cases. >> >> >> >> --- >> >> .../bindings/display/sunxi/sun4i-drm.txt | 36 ++++++++++++++++------ >> >> 1 file changed, 27 insertions(+), 9 deletions(-) >> > >> > Acked-by: Rob Herring <robh@kernel.org> >> >> Maxime, this patch seems to have fallen through the cracks. >> >> Could you queue it as a fix for 4.13? > > Sorry, I don't know why I overlooked it. > > Is it really 4.13 material though? It doesn't look that urgent. Unless I'm mistaken, this clarifies the numbering scheme introduced in 4.13. I'd say that's enough reason to have it in the same release. But I should update the diagram first. The backend <-> TCON mux is missing. And maybe a Fixes tag. ChenYu
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-07-17 08:30 +0200 |
| Subject | Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability |
| Message-ID | <u47HA-1mx-9@gated-at.bofh.it> |
| In reply to | #1685468 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Wed, Jul 12, 2017 at 10:38:38AM +0800, Chen-Yu Tsai wrote: > On Wed, Jul 12, 2017 at 3:31 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Jul 10, 2017 at 11:48:00PM +0800, Chen-Yu Tsai wrote: > >> On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@kernel.org> wrote: > >> > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote: > >> >> The explanation for the endpoint ID numbering scheme is convoluted > >> >> and hard to understand. > >> >> > >> >> This patch aims to improve the readability of it by combining the > >> >> existing two paragraphs, while also providing a diagram example, > >> >> and how endpoints should be numbered based on that example. > >> >> > >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> >> --- > >> >> > >> >> Hope this helps. I'm not sure I can improve this even more without > >> >> spelling out all cases. > >> >> > >> >> --- > >> >> .../bindings/display/sunxi/sun4i-drm.txt | 36 ++++++++++++++++------ > >> >> 1 file changed, 27 insertions(+), 9 deletions(-) > >> > > >> > Acked-by: Rob Herring <robh@kernel.org> > >> > >> Maxime, this patch seems to have fallen through the cracks. > >> > >> Could you queue it as a fix for 4.13? > > > > Sorry, I don't know why I overlooked it. > > > > Is it really 4.13 material though? It doesn't look that urgent. > > Unless I'm mistaken, this clarifies the numbering scheme introduced > in 4.13. I'd say that's enough reason to have it in the same release. > > But I should update the diagram first. The backend <-> TCON mux is > missing. And maybe a Fixes tag. If it's just clarification, I don't think we should push it as a fix, but and it can definitely wait. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web