Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1687000 > unrolled thread
| Started by | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| First post | 2017-07-14 03:10 +0200 |
| Last post | 2017-07-18 03:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] f2fs: include seq_file.h for sysfs.c Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-14 03:10 +0200
Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c Chao Yu <chao@kernel.org> - 2017-07-17 16:30 +0200
Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-17 19:00 +0200
Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c Chao Yu <yuchao0@huawei.com> - 2017-07-18 03:30 +0200
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-07-14 03:10 +0200 |
| Subject | [PATCH] f2fs: include seq_file.h for sysfs.c |
| Message-ID | <u2Xhf-4Dh-3@gated-at.bofh.it> |
This patch includes seq_file.h to avoid compile error. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index 9adc202fcd6f..71191d89917d 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -11,6 +11,7 @@ */ #include <linux/proc_fs.h> #include <linux/f2fs_fs.h> +#include <linux/seq_file.h> #include "f2fs.h" #include "segment.h" -- 2.13.0.rc1.294.g07d810a77f-goog
[toc] | [next] | [standalone]
| From | Chao Yu <chao@kernel.org> |
|---|---|
| Date | 2017-07-17 16:30 +0200 |
| Subject | Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c |
| Message-ID | <u4fc5-6e7-1@gated-at.bofh.it> |
| In reply to | #1687000 |
Hi Jaegeuk,
On 2017/7/14 9:01, Jaegeuk Kim wrote:
> This patch includes seq_file.h to avoid compile error.
I didn't hit the error, I guess that's because we have included f2fs_fs.h
in sysfs.c, the inclusion relation is like this:
- sysfs.c
- f2fs_fs.h
- pagemap.h
- fs.h
- struct seq_file
Thanks,
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 9adc202fcd6f..71191d89917d 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -11,6 +11,7 @@
> */
> #include <linux/proc_fs.h>
> #include <linux/f2fs_fs.h>
> +#include <linux/seq_file.h>
>
> #include "f2fs.h"
> #include "segment.h"
>
[toc] | [prev] | [next] | [standalone]
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-07-17 19:00 +0200 |
| Subject | Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c |
| Message-ID | <u4hxg-7xZ-27@gated-at.bofh.it> |
| In reply to | #1689097 |
On 07/17, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/7/14 9:01, Jaegeuk Kim wrote: > > This patch includes seq_file.h to avoid compile error. > > I didn't hit the error, I guess that's because we have included f2fs_fs.h > in sysfs.c, the inclusion relation is like this: > - sysfs.c > - f2fs_fs.h > - pagemap.h > - fs.h > - struct seq_file What about seq ops such as seq_puts? Thanks, > > Thanks, > > > > > Signed-off-by: Eric Biggers <ebiggers@google.com> > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/sysfs.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index 9adc202fcd6f..71191d89917d 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -11,6 +11,7 @@ > > */ > > #include <linux/proc_fs.h> > > #include <linux/f2fs_fs.h> > > +#include <linux/seq_file.h> > > > > #include "f2fs.h" > > #include "segment.h" > >
[toc] | [prev] | [next] | [standalone]
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-07-18 03:30 +0200 |
| Subject | Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c |
| Message-ID | <u4puO-4ho-11@gated-at.bofh.it> |
| In reply to | #1689268 |
On 2017/7/18 0:55, Jaegeuk Kim wrote:
> On 07/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2017/7/14 9:01, Jaegeuk Kim wrote:
>>> This patch includes seq_file.h to avoid compile error.
>>
>> I didn't hit the error, I guess that's because we have included f2fs_fs.h
>> in sysfs.c, the inclusion relation is like this:
>> - sysfs.c
>> - f2fs_fs.h
>> - pagemap.h
>> - fs.h
>> - struct seq_file
>
> What about seq ops such as seq_puts?
- sysfs.c
- segment.h
- linux/backing-dev.h
- linux/writeback.h
#ifdef CONFIG_CGROUP_WRITEBACK
- linux/cgroup.h
- linux/seq_file.h
#endif
So it looks that there is no compiling error in my environment because
of CONFIG_CGROUP_WRITEBACK was defined.
Anyway, please add:
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
>
> Thanks,
>
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@google.com>
>>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>>> ---
>>> fs/f2fs/sysfs.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>>> index 9adc202fcd6f..71191d89917d 100644
>>> --- a/fs/f2fs/sysfs.c
>>> +++ b/fs/f2fs/sysfs.c
>>> @@ -11,6 +11,7 @@
>>> */
>>> #include <linux/proc_fs.h>
>>> #include <linux/f2fs_fs.h>
>>> +#include <linux/seq_file.h>
>>>
>>> #include "f2fs.h"
>>> #include "segment.h"
>>>
>
> .
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web