Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1686974 > unrolled thread

Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

Started byBrendan Higgins <brendanhiggins@google.com>
First post2017-07-14 00:50 +0200
Last post2017-07-14 09:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-07-14 00:50 +0200
    Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-07-14 09:20 +0200

#1686974 — Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

FromBrendan Higgins <brendanhiggins@google.com>
Date2017-07-14 00:50 +0200
SubjectRe: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C
Message-ID<u2V5L-39v-11@gated-at.bofh.it>
Sorry, went on vacation and then forgot about our conversion.

>> the struct i2c_bus_recovery_info. Is i2c_generic_scl_recovery supposed
>> to be part of the user interface, or is it just intended to help put the
>> main recovery function together?
>
> Sorry, I don't understand the question. What do you mean?
>

What I meant is that it looks like the only use of it is putting
together a default
recovery function, but I was wondering if it is fair to use it on its own.
Basically what I was asking is whether I could use i2c_generic_scl_recovery
in the case where SCL is hung.

I think I have a pretty good idea of what to do, I should probably just put
together an RFC patch.

[toc] | [next] | [standalone]


#1687126

FromWolfram Sang <wsa@the-dreams.de>
Date2017-07-14 09:20 +0200
Message-ID<u333k-8vz-3@gated-at.bofh.it>
In reply to#1686974

[Multipart message — attachments visible in raw view] — view raw

> Basically what I was asking is whether I could use i2c_generic_scl_recovery
> in the case where SCL is hung.

The name is a bit misleading, I am afraid. Recovery can only be used when
SDA is stuck low. And to fix this it *uses* SCL toggling to get out of
it. And 'generic_scl' means 'gimme some SCL to control and I will toggle
it'. Compared to 'gpio_recovery' which will do all the GPIO handling for
you.

When SCL is hung, you can only reset the device which forces SCL low.

> I think I have a pretty good idea of what to do, I should probably just put
> together an RFC patch.

Sure.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web