Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684977 > unrolled thread

[PATCH] net: stmmac: make const array route_possibilities static

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: stmmac: make const array route_possibilities static Colin King <colin.king@canonical.com> - 2017-07-11 13:20 +0200
    Re: [PATCH] net: stmmac: make const array route_possibilities  static David Miller <davem@davemloft.net> - 2017-07-13 18:30 +0200

#1684977 — [PATCH] net: stmmac: make const array route_possibilities static

From: Colin Ian King <colin.king@canonical.com>

Don't populate array route_possibilities on the stack but make it
static const.  Makes the object code a little smaller by 85 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   9901	   2448	      0	  12349	   303d	dwmac4_core.o

After:
   text	   data	    bss	    dec	    hex	filename
   9760	   2504	      0	  12264	   2fe8	dwmac4_core.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index f233bf8b4ebb..c4407e8e39a3 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -117,7 +117,7 @@ static void dwmac4_tx_queue_routing(struct mac_device_info *hw,
 	void __iomem *ioaddr = hw->pcsr;
 	u32 value;
 
-	const struct stmmac_rx_routing route_possibilities[] = {
+	static const struct stmmac_rx_routing route_possibilities[] = {
 		{ GMAC_RXQCTRL_AVCPQ_MASK, GMAC_RXQCTRL_AVCPQ_SHIFT },
 		{ GMAC_RXQCTRL_PTPQ_MASK, GMAC_RXQCTRL_PTPQ_SHIFT },
 		{ GMAC_RXQCTRL_DCBCPQ_MASK, GMAC_RXQCTRL_DCBCPQ_SHIFT },
-- 
2.11.0

[toc] | [next] | [standalone]

#1686769 — Re: [PATCH] net: stmmac: make const array route_possibilities static

From: Colin King <colin.king@canonical.com>
Date: Tue, 11 Jul 2017 12:18:48 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate array route_possibilities on the stack but make it
> static const.  Makes the object code a little smaller by 85 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    9901	   2448	      0	  12349	   303d	dwmac4_core.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    9760	   2504	      0	  12264	   2fe8	dwmac4_core.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web