Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1686351 > unrolled thread
| Started by | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| First post | 2017-07-13 10:10 +0200 |
| Last post | 2017-07-13 11:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes Shawn Guo <shawnguo@kernel.org> - 2017-07-13 10:10 +0200
RE: [PATCH] arm64: dts: ls1012a: add USB host controller nodes Ran Wang <ran.wang_1@nxp.com> - 2017-07-13 10:50 +0200
Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes Shawn Guo <shawnguo@kernel.org> - 2017-07-13 11:00 +0200
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2017-07-13 10:10 +0200 |
| Subject | Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes |
| Message-ID | <u2Hma-34F-3@gated-at.bofh.it> |
On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:
> LS1012A has one USB 3.0(DWC3) controller and
> one USB 2.0 controller.
>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> index b497ac1..8aa2dcf 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -411,6 +411,23 @@
> <&clockgen 4 3>;
> };
>
> + usb0: usb3@2f00000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x2f00000 0x0 0x10000>;
> + interrupts = <0 60 0x4>;
> + dr_mode = "host";
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,dis_rxdet_inp3_quirk;
> + };
> +
> + usb1: usb2@8600000 {
> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> + reg = <0x0 0x8600000 0x0 0x1000>;
> + interrupts = <0 139 0x4>;
> + dr_mode = "host";
> + phy_type = "ulpi";
> + };
Please keep the nodes sorted in unit-address.
Shawn
> +
> sata: sata@3200000 {
> compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> reg = <0x0 0x3200000 0x0 0x10000>,
> --
> 2.1.0.27.g96db324
>
[toc] | [next] | [standalone]
| From | Ran Wang <ran.wang_1@nxp.com> |
|---|---|
| Date | 2017-07-13 10:50 +0200 |
| Message-ID | <u2HYR-3iC-15@gated-at.bofh.it> |
| In reply to | #1686351 |
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, July 13, 2017 4:07 PM
> To: Ran Wang <ran.wang_1@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will
> Deacon <will.deacon@arm.com>; Andy Tang <andy.tang@nxp.com>; Harninder
> Rai <harninder.rai@nxp.com>; Horia Geantă <horia.geanta@nxp.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; moderated list:ARM64 PORT (AARCH64
> ARCHITECTURE) <linux-arm-kernel@lists.infradead.org>; open list <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
>
> On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:
> > LS1012A has one USB 3.0(DWC3) controller and one USB 2.0 controller.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > index b497ac1..8aa2dcf 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > @@ -411,6 +411,23 @@
> > <&clockgen 4 3>;
> > };
> >
> > + usb0: usb3@2f00000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x2f00000 0x0 0x10000>;
> > + interrupts = <0 60 0x4>;
> > + dr_mode = "host";
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,dis_rxdet_inp3_quirk;
> > + };
> > +
> > + usb1: usb2@8600000 {
> > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > + reg = <0x0 0x8600000 0x0 0x1000>;
> > + interrupts = <0 139 0x4>;
> > + dr_mode = "host";
> > + phy_type = "ulpi";
> > + };
>
> Please keep the nodes sorted in unit-address.
>
> Shawn
Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before '@8600000 '?
I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.
Ran
>
> > +
> > sata: sata@3200000 {
> > compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > reg = <0x0 0x3200000 0x0 0x10000>,
> > --
> > 2.1.0.27.g96db324
> >
[toc] | [prev] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2017-07-13 11:00 +0200 |
| Message-ID | <u2I8y-3lP-19@gated-at.bofh.it> |
| In reply to | #1686387 |
On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > index b497ac1..8aa2dcf 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > @@ -411,6 +411,23 @@
> > > <&clockgen 4 3>;
> > > };
> > >
> > > + usb0: usb3@2f00000 {
> > > + compatible = "snps,dwc3";
> > > + reg = <0x0 0x2f00000 0x0 0x10000>;
> > > + interrupts = <0 60 0x4>;
> > > + dr_mode = "host";
> > > + snps,quirk-frame-length-adjustment = <0x20>;
> > > + snps,dis_rxdet_inp3_quirk;
> > > + };
> > > +
> > > + usb1: usb2@8600000 {
> > > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > > + reg = <0x0 0x8600000 0x0 0x1000>;
> > > + interrupts = <0 139 0x4>;
> > > + dr_mode = "host";
> > > + phy_type = "ulpi";
> > > + };
> >
> > Please keep the nodes sorted in unit-address.
> >
> > Shawn
> Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before '@8600000 '?
> I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.
The nodes under simple-bus are maintained in order of unit-address.
Please respect that.
usb2@8600000 should go after sata@3200000 with the current nodes.
Shawn
> > > +
> > > sata: sata@3200000 {
> > > compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > > reg = <0x0 0x3200000 0x0 0x10000>,
> > > --
> > > 2.1.0.27.g96db324
> > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web