Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1686338 > unrolled thread
| Started by | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| First post | 2017-07-13 10:00 +0200 |
| Last post | 2017-07-17 17:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Kefeng Wang <wangkefeng.wang@huawei.com> - 2017-07-13 10:00 +0200
Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Ilya Dryomov <idryomov@gmail.com> - 2017-07-14 12:10 +0200
Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Kefeng Wang <wangkefeng.wang@huawei.com> - 2017-07-14 13:30 +0200
Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Ilya Dryomov <idryomov@gmail.com> - 2017-07-17 17:10 +0200
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Date | 2017-07-13 10:00 +0200 |
| Subject | [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock |
| Message-ID | <u2Hcu-2Mh-17@gated-at.bofh.it> |
drivers/block/rbd.c: In function 'rbd_acquire_lock':
drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Silence the warning, found it when built old kernel(3.10) with
OBS(opensuse build service).
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index b008b6a..b640ad8 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work)
struct rbd_device *rbd_dev = container_of(to_delayed_work(work),
struct rbd_device, lock_dwork);
enum rbd_lock_state lock_state;
- int ret;
+ int ret = 0;
dout("%s rbd_dev %p\n", __func__, rbd_dev);
again:
--
1.7.12.4
[toc] | [next] | [standalone]
| From | Ilya Dryomov <idryomov@gmail.com> |
|---|---|
| Date | 2017-07-14 12:10 +0200 |
| Message-ID | <u35HP-1Xa-13@gated-at.bofh.it> |
| In reply to | #1686338 |
On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> drivers/block/rbd.c: In function 'rbd_acquire_lock':
> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Silence the warning, found it when built old kernel(3.10) with
> OBS(opensuse build service).
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index b008b6a..b640ad8 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work)
> struct rbd_device *rbd_dev = container_of(to_delayed_work(work),
> struct rbd_device, lock_dwork);
> enum rbd_lock_state lock_state;
> - int ret;
> + int ret = 0;
>
> dout("%s rbd_dev %p\n", __func__, rbd_dev);
> again:
How did you get rbd_acquire_lock() into 3.10?
Thanks,
Ilya
[toc] | [prev] | [next] | [standalone]
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Date | 2017-07-14 13:30 +0200 |
| Message-ID | <u36Xg-2Gt-3@gated-at.bofh.it> |
| In reply to | #1687231 |
On 2017/7/14 18:06, Ilya Dryomov wrote:
> On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> drivers/block/rbd.c: In function 'rbd_acquire_lock':
>> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>
>> Silence the warning, found it when built old kernel(3.10) with
>> OBS(opensuse build service).
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> drivers/block/rbd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>> index b008b6a..b640ad8 100644
>> --- a/drivers/block/rbd.c
>> +++ b/drivers/block/rbd.c
>> @@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work)
>> struct rbd_device *rbd_dev = container_of(to_delayed_work(work),
>> struct rbd_device, lock_dwork);
>> enum rbd_lock_state lock_state;
>> - int ret;
>> + int ret = 0;
>>
>> dout("%s rbd_dev %p\n", __func__, rbd_dev);
>> again:
>
> How did you get rbd_acquire_lock() into 3.10?
Using CentOS 7.3.
>
> Thanks,
>
> Ilya
>
>
[toc] | [prev] | [next] | [standalone]
| From | Ilya Dryomov <idryomov@gmail.com> |
|---|---|
| Date | 2017-07-17 17:10 +0200 |
| Message-ID | <u4fON-6GU-5@gated-at.bofh.it> |
| In reply to | #1687268 |
On Fri, Jul 14, 2017 at 1:25 PM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>
> On 2017/7/14 18:06, Ilya Dryomov wrote:
>> On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> drivers/block/rbd.c: In function 'rbd_acquire_lock':
>>> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>>
>>> Silence the warning, found it when built old kernel(3.10) with
>>> OBS(opensuse build service).
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>> drivers/block/rbd.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>>> index b008b6a..b640ad8 100644
>>> --- a/drivers/block/rbd.c
>>> +++ b/drivers/block/rbd.c
>>> @@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work)
>>> struct rbd_device *rbd_dev = container_of(to_delayed_work(work),
>>> struct rbd_device, lock_dwork);
>>> enum rbd_lock_state lock_state;
>>> - int ret;
>>> + int ret = 0;
>>>
>>> dout("%s rbd_dev %p\n", __func__, rbd_dev);
>>> again:
>>
>> How did you get rbd_acquire_lock() into 3.10?
>
> Using CentOS 7.3.
Applied.
Thanks,
Ilya
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web