Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1686258 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-07-13 07:50 +0200 |
| Last post | 2017-07-13 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: tegra: constify snd_soc_dai_ops structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 07:50 +0200
Re: [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure Jon Hunter <jonathanh@nvidia.com> - 2017-07-13 16:20 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-13 07:50 +0200 |
| Subject | [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure |
| Message-ID | <u2FaF-1xh-11@gated-at.bofh.it> |
This structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/soc/tegra/tegra30_i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
index b2b279c..0b176ea 100644
--- a/sound/soc/tegra/tegra30_i2s.c
+++ b/sound/soc/tegra/tegra30_i2s.c
@@ -275,7 +275,7 @@ static int tegra30_i2s_probe(struct snd_soc_dai *dai)
return 0;
}
-static struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
+static const struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
.set_fmt = tegra30_i2s_set_fmt,
.hw_params = tegra30_i2s_hw_params,
.trigger = tegra30_i2s_trigger,
--
2.5.0
[toc] | [next] | [standalone]
| From | Jon Hunter <jonathanh@nvidia.com> |
|---|---|
| Date | 2017-07-13 16:20 +0200 |
| Message-ID | <u2N8f-6Ff-31@gated-at.bofh.it> |
| In reply to | #1686258 |
On 13/07/17 06:47, Gustavo A. R. Silva wrote:
> This structure is only stored in the ops field of a snd_soc_dai_driver
> structure. That field is declared const, so snd_soc_dai_ops structures
> that have this property can be declared as const also.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> sound/soc/tegra/tegra30_i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
> index b2b279c..0b176ea 100644
> --- a/sound/soc/tegra/tegra30_i2s.c
> +++ b/sound/soc/tegra/tegra30_i2s.c
> @@ -275,7 +275,7 @@ static int tegra30_i2s_probe(struct snd_soc_dai *dai)
> return 0;
> }
>
> -static struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
> +static const struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
> .set_fmt = tegra30_i2s_set_fmt,
> .hw_params = tegra30_i2s_hw_params,
> .trigger = tegra30_i2s_trigger,
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web